From: Arnd Bergmann <arnd@arndb.de>
To: Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Baoyou Xie <baoyou.xie@linaro.org>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 0/5] bfa: fix W=1 build warnings
Date: Tue, 2 Aug 2016 17:22:45 +0200 [thread overview]
Message-ID: <20160802152250.1964074-1-arnd@arndb.de> (raw)
I tried to build an allmodconfig kernel with W=1, and the bfa
driver stuck out for having the most warnings in one file, so
I decided to send patches for all of these and make the driver
build cleanly with the extra warnings enabled.
As most warnings were for functions that lacked a 'static',
I marked them that way, and also used a script to look for
further functions that have a declaration but can also be static.
Overall, this saves around 10% of the size of the driver
module:
text data bss dec hex filename
232027 3012 976 236015 399ef drivers/scsi/bfa/bfa-before.o
221851 2996 908 225755 371db drivers/scsi/bfa/bfa-after.o
Arnd
Arnd Bergmann (5):
bfa: mark symbols static where possible
bfa: remove unused variables
bfa: rename some global variables
bfa: remove unused functions from fbbuild.c
bfa: remove more unused functions
drivers/scsi/bfa/bfa.h | 17 --
drivers/scsi/bfa/bfa_core.c | 54 +---
drivers/scsi/bfa/bfa_fcbuild.c | 609 +--------------------------------------
drivers/scsi/bfa/bfa_fcbuild.h | 90 ------
drivers/scsi/bfa/bfa_fcpim.c | 81 +++---
drivers/scsi/bfa/bfa_fcpim.h | 26 --
drivers/scsi/bfa/bfa_fcs.c | 31 +-
drivers/scsi/bfa/bfa_fcs.h | 54 ----
drivers/scsi/bfa/bfa_fcs_lport.c | 211 +++-----------
drivers/scsi/bfa/bfa_fcs_rport.c | 48 +--
drivers/scsi/bfa/bfa_ioc.c | 83 ++----
drivers/scsi/bfa/bfa_ioc.h | 25 --
drivers/scsi/bfa/bfa_ioc_cb.c | 3 +-
drivers/scsi/bfa/bfa_ioc_ct.c | 12 +-
drivers/scsi/bfa/bfa_plog.h | 8 -
drivers/scsi/bfa/bfa_port.c | 6 +-
drivers/scsi/bfa/bfa_port.h | 1 -
drivers/scsi/bfa/bfa_svc.c | 95 ++----
drivers/scsi/bfa/bfa_svc.h | 17 --
drivers/scsi/bfa/bfad.c | 128 ++++----
drivers/scsi/bfa/bfad_attr.c | 9 +-
drivers/scsi/bfa/bfad_bsg.c | 224 +++++++-------
drivers/scsi/bfa/bfad_drv.h | 49 +---
drivers/scsi/bfa/bfad_im.c | 29 +-
drivers/scsi/bfa/bfad_im.h | 10 -
25 files changed, 395 insertions(+), 1525 deletions(-)
--
2.9.0
next reply other threads:[~2016-08-02 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 15:22 Arnd Bergmann [this message]
2016-08-02 15:22 ` [PATCH 1/5] bfa: mark symbols static where possible Arnd Bergmann
2016-08-03 4:45 ` kbuild test robot
2016-08-03 7:46 ` Arnd Bergmann
2016-08-10 5:20 ` Sudarsana Kalluru
2016-08-02 15:22 ` [PATCH 2/5] bfa: remove unused variables Arnd Bergmann
2016-08-02 15:22 ` [PATCH 3/5] bfa: rename some global variables Arnd Bergmann
2016-08-02 15:22 ` [PATCH 4/5] bfa: remove unused functions from fbbuild.c Arnd Bergmann
2016-08-02 15:22 ` [PATCH 5/5] bfa: remove more unused functions Arnd Bergmann
2016-08-10 5:28 ` [PATCH 0/5] bfa: fix W=1 build warnings Sudarsana Kalluru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802152250.1964074-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anil.gurumurthy@qlogic.com \
--cc=baoyou.xie@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sudarsana.kalluru@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox