* Re: [PATCH] block: Fix secure erase
[not found] ` <20160815181457.GA9781@lst.de>
@ 2016-08-16 7:20 ` Adrian Hunter
2016-08-17 0:52 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Hunter @ 2016-08-16 7:20 UTC (permalink / raw)
To: Christoph Hellwig, Shaun Tancheff
Cc: Jens Axboe, Ulf Hansson, linux-mmc, linux-block, LKML,
Josh Bingaman, Vinayak Holikatti, Joao Pinto, linux-scsi,
Martin K. Petersen, Pawel Wodkowski
On 15/08/16 21:14, Christoph Hellwig wrote:
> On Mon, Aug 15, 2016 at 11:43:12AM -0500, Shaun Tancheff wrote:
>> Hmm ... Since REQ_SECURE implied REQ_DISCARD doesn't this
>> mean that we should include REQ_OP_SECURE_ERASE checking
>> wherever REQ_OP_DISCARD is being checked now in drivers/scsi/sd.c ?
>>
>> (It's only in 3 spots so it's a quickie patch)
>
> SCSI doesn't support secure erase operations. Only MMC really
> supports it, plus the usual cargo culting in Xen blkfront that's
> probably never been tested..
>
I left SCSI out because support does not exist at the moment.
However there is UFS which is seen as the replacement for eMMC.
And there is a patch to add support for BLKSECDISCARD:
http://marc.info/?l=linux-scsi&m=146953519016056
So SCSI will need updating if that is to go in.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] block: Fix secure erase
2016-08-16 7:20 ` [PATCH] block: Fix secure erase Adrian Hunter
@ 2016-08-17 0:52 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2016-08-17 0:52 UTC (permalink / raw)
To: Adrian Hunter
Cc: Christoph Hellwig, Shaun Tancheff, Jens Axboe, Ulf Hansson,
linux-mmc, linux-block, LKML, Josh Bingaman, Vinayak Holikatti,
Joao Pinto, linux-scsi, Martin K. Petersen, Pawel Wodkowski
On Tue, Aug 16, 2016 at 10:20:25AM +0300, Adrian Hunter wrote:
> On 15/08/16 21:14, Christoph Hellwig wrote:
> > On Mon, Aug 15, 2016 at 11:43:12AM -0500, Shaun Tancheff wrote:
> >> Hmm ... Since REQ_SECURE implied REQ_DISCARD doesn't this
> >> mean that we should include REQ_OP_SECURE_ERASE checking
> >> wherever REQ_OP_DISCARD is being checked now in drivers/scsi/sd.c ?
> >>
> >> (It's only in 3 spots so it's a quickie patch)
> >
> > SCSI doesn't support secure erase operations. Only MMC really
> > supports it, plus the usual cargo culting in Xen blkfront that's
> > probably never been tested..
> >
>
> I left SCSI out because support does not exist at the moment.
> However there is UFS which is seen as the replacement for eMMC.
> And there is a patch to add support for BLKSECDISCARD:
>
> http://marc.info/?l=linux-scsi&m=146953519016056
>
> So SCSI will need updating if that is to go in.
That patch is complete crap and if anyone thinks they'd get shit like
that in they are on the same crack that apparently the authors of the
UFS spec are on.
If you want secure discard supported in UFS get a command for into
SBC instead of bypassing the command set.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-17 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160811140533.GA16543@lst.de>
[not found] ` <1471270071-28921-1-git-send-email-adrian.hunter@intel.com>
[not found] ` <CAJVOszDxKmaEEsg49yMT+Vr8oNbKLmgAGJ_P9KNa=zQcqcx+CQ@mail.gmail.com>
[not found] ` <20160815181457.GA9781@lst.de>
2016-08-16 7:20 ` [PATCH] block: Fix secure erase Adrian Hunter
2016-08-17 0:52 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).