From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tomas Henzl <thenzl@redhat.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
Marco Grassi <marco.gra@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ching Huang <ching2048@areca.com.tw>,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinicke <hare@suse.de>,
linux-scsi@vger.kernel.org, security@kernel.org
Subject: Re: [patch] arcmsr: buffer overflow in arcmsr_iop_message_xfer()
Date: Thu, 15 Sep 2016 16:43:56 +0300 [thread overview]
Message-ID: <20160915134356.GG26713@mwanda> (raw)
In-Reply-To: <ff1f18b9-8e5b-93d8-1292-c74529676066@redhat.com>
On Thu, Sep 15, 2016 at 03:19:12PM +0200, Tomas Henzl wrote:
> > @@ -2397,6 +2398,10 @@ static int arcmsr_iop_message_xfer(struct AdapterControlBlock *acb,
> > }
> > ptmpuserbuffer = ver_addr;
> > user_len = pcmdmessagefld->cmdmessage.Length;
> > + if (user_len > ARCMSR_API_DATA_BUFLEN) {
> > + retvalue = ARCMSR_MESSAGE_FAIL;
>
> Hi,
> I think that a 'kfree(ver_addr);' should be added here.
> With that you may add my reviewed-by.
Oops... Thanks for catching that. I should have been more careful.
v2 on the way.
regards,
dan carpenter
next prev parent reply other threads:[~2016-09-15 13:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFkTriJHaO0-O0AXKWSZW6bXT_2m+VqRdwshFsgeq1=Bjfn_OQ@mail.gmail.com>
2016-09-15 12:01 ` [patch] arcmsr: buffer overflow in arcmsr_iop_message_xfer() Dan Carpenter
2016-09-15 13:19 ` Tomas Henzl
2016-09-15 13:43 ` Dan Carpenter [this message]
2016-09-15 13:44 ` [patch v2] " Dan Carpenter
2016-09-15 13:59 ` Martin K. Petersen
2016-09-23 11:22 ` Borislav Petkov
2016-09-26 11:58 ` Johannes Thumshirn
2016-09-26 13:29 ` Tomas Henzl
2016-09-27 1:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915134356.GG26713@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ching2048@areca.com.tw \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=marco.gra@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=security@kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).