From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 08/12] scsi/ncr5380: Use correct types for device register accessors Date: Mon, 10 Oct 2016 10:13:47 +0100 Message-ID: <20161010091347.GW1041@n2100.armlinux.org.uk> References: <7f9f43fa2d3ba08a3277b749ea38acad3c8e8337.1476051962.git.fthain@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <7f9f43fa2d3ba08a3277b749ea38acad3c8e8337.1476051962.git.fthain@telegraphics.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Finn Thain Cc: Michael Schmitz , Ondrej Zary , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , linux-arm-kernel@lists.infradead.org List-Id: linux-scsi@vger.kernel.org On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote: > For timeout values adopt unsigned long, which is the type of jiffies etc. > > For chip register values and bit masks pass u8, which is the return type > of readb, inb etc. > > For device register offsets adopt unsigned int, as it is suitable for > adding to base addresses. > > Pass the NCR5380_hostdata pointer to the board-specific routines instead > of the Scsi_Host pointer. The board-specific code is concerned with > hardware and not with SCSI protocol or the mid-layer. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke > Tested-by: Ondrej Zary > Tested-by: Michael Schmitz > --- > drivers/scsi/arm/cumana_1.c | 20 +++++++++++--------- > drivers/scsi/arm/oak.c | 6 ++---- For these two: Acked-by: Russell King Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.