From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 07/12] scsi/ncr5380: Store IO ports and addresses in host private data Date: Mon, 10 Oct 2016 10:19:49 +0100 Message-ID: <20161010091949.GZ1041@n2100.armlinux.org.uk> References: <5c9f6b4913bc8bc4938d2de0bb19d4289226ec26.1476051962.git.fthain@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5c9f6b4913bc8bc4938d2de0bb19d4289226ec26.1476051962.git.fthain@telegraphics.com.au> Sender: linux-kernel-owner@vger.kernel.org To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-kernel@lists.infradead.org, Michael Schmitz , Ondrej Zary , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote: > The various 5380 drivers inconsistently store register pointers > either in the Scsi_Host struct "legacy crap" area or in special, > board-specific members of the NCR5380_hostdata struct. Uniform > use of the latter struct makes for simpler and faster code (see > the following patches) and helps to reduce use of the > NCR5380_implementation_fields macro. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke > Tested-by: Ondrej Zary > Tested-by: Michael Schmitz > --- > drivers/scsi/arm/cumana_1.c | 60 ++++++++++++++++++++-------------------- > drivers/scsi/arm/oak.c | 23 ++++++++-------- For these two, Acked-by: Russell King -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.