From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 00/44] Convert FibreChannel bsg code to use bsg-lib
Date: Tue, 11 Oct 2016 09:49:38 -0700 [thread overview]
Message-ID: <20161011164938.GA6083@infradead.org> (raw)
In-Reply-To: <cover.1476180827.git.jthumshirn@suse.de>
Hi Johannes,
this looks great to me. But is there a chance to consolidate it into
a more manageable set of patches? E.g. all the patches to call
export fc_bsg_jobdone, use it directly and remove the function pointer
could go together, possibly even including the new calling convention.
Similar all the patches about fc_bsg_to_shost could be merged into one,
and if we add the bsg refcounting early, we could maybe skip a few
steps of the conversion later on?
next prev parent reply other threads:[~2016-10-11 16:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 11:28 [PATCH 00/44] Convert FibreChannel bsg code to use bsg-lib Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 01/44] scsi: Get rid of struct fc_bsg_buffer Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 02/44] bfa: don't use fc_bsg_job::request and fc_bsg_job::reply directly Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 03/44] zfcp: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 04/44] ibmvfc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 05/44] lpfc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 06/44] qla2xxx: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 08/44] scsi: fc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 09/44] scsi: fc: Export fc_bsg_jobdone Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 10/44] zfcp: Use fc_bsg_jobdone() Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 11/44] bfa: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 12/44] ibmvfc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 14/44] lpfc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 15/44] qla2xxx: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 16/44] scsi: fc: remove job_done method from struct fc_bsg_job Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 18/44] scsi: fc: provide fc_bsg_to_shost() helper Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 19/44] scsi: fc: use fc_bsg_to_shost() to access a bsg_job's Scsi_Host Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 20/44] bfa: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 21/44] lpfc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 22/44] qla2xxx: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 24/44] ibmvfc: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 25/44] zfcp: " Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 26/44] scsi: fc: provide fc_bsg_to_rport() helper Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 27/44] scsi: fc: use fc_bsg_to_rport() to access a bsg_job's rport Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 28/44] zfcp: " Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 29/44] qla2xxx: " Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 30/44] lpfc: " Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 32/44] ibmvfc: " Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 34/44] scsi: fc: implement kref backed reference counting Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 35/44] block: add reference counting for struct bsg_job Johannes Thumshirn
[not found] ` <cover.1476180827.git.jthumshirn-l3A5Bk7waGM@public.gmane.org>
2016-10-11 11:28 ` [PATCH 07/44] libfc: don't use fc_bsg_job::request and fc_bsg_job::reply directly Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 13/44] libfc: Use fc_bsg_jobdone() Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 17/44] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done Johannes Thumshirn
2016-10-11 11:28 ` [PATCH 23/44] libfc: use fc_bsg_to_shost() to access a bsg_job's Scsi_Host Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 31/44] libfc: use fc_bsg_to_rport() to access a bsg_job's rport Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 33/44] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 36/44] scsi: change FC drivers to use 'struct bsg_job' Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 37/44] block: export bsg_destroy_job Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 38/44] scsi: fc: Use bsg_destroy_job Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 39/44] block: export bsg_softirq_done Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 40/44] scsi: fc: use bsg_softirq_done Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 41/44] scsi: fc: use bsg_job_done Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 42/44] block: add bsg_job_put() and bsg_job_get() Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 43/44] scsi: fc: move FC transport's bsg code to bsg-lib Johannes Thumshirn
2016-10-11 11:29 ` [PATCH 44/44] block: unexport bsg_softirq_done() again Johannes Thumshirn
2016-10-11 16:49 ` Christoph Hellwig [this message]
2016-10-12 7:06 ` [PATCH 00/44] Convert FibreChannel bsg code to use bsg-lib Johannes Thumshirn
2016-10-11 18:00 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011164938.GA6083@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).