From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 07/11] dm: Fix a race condition related to stopping and starting queues Date: Wed, 19 Oct 2016 15:30:50 +0200 Message-ID: <20161019133050.GG6323@lst.de> References: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:41990 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942005AbcJSOqe (ORCPT ); Wed, 19 Oct 2016 10:46:34 -0400 Content-Disposition: inline In-Reply-To: <1e89a7d7-5cae-40b1-ce31-09d630e6f33d@sandisk.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: Jens Axboe , Christoph Hellwig , James Bottomley , "Martin K. Petersen" , Mike Snitzer , Doug Ledford , Keith Busch , Ming Lin , Laurence Oberman , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-nvme@lists.infradead.org" Looks good: Reviewed-by: Christoph Hellwig FYI, I wonder how many of the blk_mq_stop_hw_queues do not need the quiesce call. In the long run it might be better to have blk_mq_stop_hw_queues to stop an quiesce, and have a __blk_mq_stop_hw_queues variant to just stop.