From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()
Date: Wed, 2 Nov 2016 16:06:56 +0100 [thread overview]
Message-ID: <20161102150655.GA14320@lst.de> (raw)
In-Reply-To: <1478036978-30583-2-git-send-email-hare@suse.de>
On Tue, Nov 01, 2016 at 10:49:36PM +0100, Hannes Reinecke wrote:
> Switch to scsi_execute_req_flags() instead of
> using the block interface directly. This will set
> REQ_QUIET and REQ_PREEMPT, but this is okay as
> we're evaluating the errors anyway and should be
> able to send the command even if the device is
> quiesced.
Actually most users are switched to scsi_get_vpd_page if I read the patch
right, which is even better. And it seems like the remaining user of
scsi_execute_req_flags could be switch to use scsi_mode_select() as well,
but maybe we should leave that out for now.
> + if (scsi_execute_req_flags(sdev, cdb, DMA_TO_DEVICE,
> + &h->ctlr->mode_select, data_size, &sshdr,
> + RDAC_TIMEOUT * HZ,
> + RDAC_RETRIES, NULL, REQ_FAILFAST_MASK)) {
Pleae use the individual failfast flags - REQ_FAILFAST_MASK is just
for block layer use.
next prev parent reply other threads:[~2016-11-02 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 21:49 [PATCHv2 0/3] scsi_dh: switch to scsi_execute_req_flags() Hannes Reinecke
2016-11-01 21:49 ` [PATCH 1/3] scsi_dh_rdac: " Hannes Reinecke
2016-11-02 15:06 ` Christoph Hellwig [this message]
2016-11-03 13:07 ` Hannes Reinecke
2016-11-02 15:44 ` Ewan D. Milne
2016-11-02 21:27 ` Hannes Reinecke
2016-11-03 16:11 ` Ewan D. Milne
2016-11-03 22:06 ` Hannes Reinecke
2016-11-01 21:49 ` [PATCH 2/3] scsi_dh_emc: " Hannes Reinecke
2016-11-02 15:08 ` Christoph Hellwig
2016-11-01 21:49 ` [PATCH 3/3] scsi_dh_hp_sw: " Hannes Reinecke
2016-11-02 15:10 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-11-03 13:20 [PATCHv3 0/3] scsi_dh: " Hannes Reinecke
2016-11-03 13:20 ` [PATCH 1/3] scsi_dh_rdac: " Hannes Reinecke
2016-10-31 17:59 [PATCH 0/3] scsi_dh: " Hannes Reinecke
2016-10-31 17:59 ` [PATCH 1/3] scsi_dh_rdac: " Hannes Reinecke
2016-11-01 14:47 ` Christoph Hellwig
2016-11-01 19:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102150655.GA14320@lst.de \
--to=hch@lst.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).