From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Chad Dupuis <chad.dupuis@qlogic.com>,
rt@linutronix.de, QLogic-Storage-Upstream@qlogic.com,
Johannes Thumshirn <jth@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker
Date: Mon, 7 Nov 2016 17:38:48 +0100 [thread overview]
Message-ID: <20161107163848.GA1421@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1611071729030.3709@nanos>
On Mon, Nov 07, 2016 at 05:31:03PM +0100, Thomas Gleixner wrote:
> On Mon, 7 Nov 2016, Christoph Hellwig wrote:
>
> > It seems like the whole damn driver should just use threaded interrupts.
> > Of course it's a giant beast and not just the iSCSI one. But even
> > if we don't go all the way I'd much prefer workqueues. kthread work
> > is simply the worst API ever and I'd prefer to not have it proliferate.
>
> That's what the patch is doing. It uses INIT_WORK() and
> schedule_work[_on](). I can't find any reference to kthread work.
You're right it does - between the incorrect subject and the fact
that it still keeps the linked list of items arounds instead of fully
using the workqueue infrastructure I was a bit confused before my
first coffee this morning. Same applies to patch 2.
next prev parent reply other threads:[~2016-11-07 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 10:09 [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker Sebastian Andrzej Siewior
2016-08-17 10:10 ` [REPOST PATCH 2/5] scsi: bnx2fc: convert per-CPU thread " Sebastian Andrzej Siewior
2016-08-17 10:10 ` [REPOST PATCH 3/5] scsi: bnx2fc: clean up header definitions Sebastian Andrzej Siewior
2016-08-17 10:10 ` [REPOST PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse Sebastian Andrzej Siewior
2016-08-17 10:10 ` [REPOST PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to worker Sebastian Andrzej Siewior
2016-09-08 12:39 ` [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker Johannes Thumshirn
2016-09-09 11:28 ` Martin K. Petersen
2016-09-13 13:28 ` Chad Dupuis
2016-09-14 17:25 ` Martin K. Petersen
2016-09-30 21:43 ` Sebastian Andrzej Siewior
2016-11-07 16:19 ` Christoph Hellwig
2016-11-07 16:31 ` [PREEMPT-RT] " Thomas Gleixner
2016-11-07 16:38 ` Christoph Hellwig [this message]
2016-11-07 16:46 ` Sebastian Andrzej Siewior
2016-11-07 16:48 ` Christoph Hellwig
2016-11-07 17:04 ` Sebastian Andrzej Siewior
2016-11-07 19:10 ` Christoph Hellwig
2016-11-08 7:24 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107163848.GA1421@lst.de \
--to=hch@lst.de \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=bigeasy@linutronix.de \
--cc=chad.dupuis@qlogic.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jth@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rt@linutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).