linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	james.smart@broadcom.com, hare@suse.de,
	linux-scsi@vger.kernel.org
Subject: Re: use PCI layer IRQ affinity in lpfc
Date: Fri, 18 Nov 2016 05:22:11 -0800	[thread overview]
Message-ID: <20161118132211.GA13756@infradead.org> (raw)
In-Reply-To: <20161118131312.jeenjqwznfap4ced@linux-x5ow.site>

On Fri, Nov 18, 2016 at 02:13:12PM +0100, Johannes Thumshirn wrote:
> This is what /proc/interrupts looks like after booting from the lpfc HBA,
> with your patches:
> 
> ettrick:~ # grep lpfc /proc/interrupts 
>   44: 2056 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI 5242880-edge lpfc
>   46: 2186 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI 5244928-edge lpfc
>   48:   69 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI 6815744-edge lpfc:sp
>   49: 2060 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI 6815745-edge lpfc:fp
>   51:   64 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI 6817792-edge lpfc:sp
>   52: 1074 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 PCI-MSI 6817793-edge lpfc:fp
> ettrick:~ # for irq in 44 46 48 49 51 52; do echo -n "$irq: "; \
> >  cat /proc/irq/$irq/smp_affinity; done
> 44: 55555555
> 46: 55555555
> 48: 55555555
> 49: 55555555
> 51: 55555555
> 52: 55555555
> ettrick:~ # 
> 
> Anything else you want me to look at?

Looks like you have non SLI-4 devices, which doesn't support
multiple queues, so patch 2 shouldn't have made a difference anyway.

But even with an SLI-4 device we'd need some actual I/O from different
CPUs to it to see how the interrupts were spread.

  parent reply	other threads:[~2016-11-18 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 15:14 use PCI layer IRQ affinity in lpfc Christoph Hellwig
2016-11-17 15:14 ` [PATCH 1/2] lpfc: use pci_irq_alloc_vectors and pci_irq_free_vectors Christoph Hellwig
2016-11-17 15:14 ` [PATCH 2/2] lpfc: use PCI-layer irq affinity handling Christoph Hellwig
2016-11-18 13:13 ` use PCI layer IRQ affinity in lpfc Johannes Thumshirn
2016-11-18 13:22   ` Hannes Reinecke
2016-11-18 13:22   ` Christoph Hellwig [this message]
2016-11-18 13:25     ` Johannes Thumshirn
2016-11-18 14:20     ` Johannes Thumshirn
2016-11-18 16:21 ` James Smart
2016-11-21 14:06   ` Christoph Hellwig
2017-01-08 15:02     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118132211.GA13756@infradead.org \
    --to=hch@infradead.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).