* [PATCH] cxgb4i: Add a missing call to neigh_release
@ 2016-11-19 17:42 Quentin Lambert
2016-11-29 16:48 ` Martin K. Petersen
2016-11-30 16:37 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Quentin Lambert @ 2016-11-19 17:42 UTC (permalink / raw)
To: Karen Xie, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel, kernel-janitors
Cc: Quentin Lambert
Most error branches following the call to dst_neigh_lookup contain
a call to neigh_release. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -1410,7 +1410,7 @@ static int init_act_open(struct cxgbi_so
csk->atid = cxgb4_alloc_atid(lldi->tids, csk);
if (csk->atid < 0) {
pr_err("%s, NO atid available.\n", ndev->name);
- return -EINVAL;
+ goto rel_resource_without_clip;
}
cxgbi_sock_set_flag(csk, CTPF_HAS_ATID);
cxgbi_sock_get(csk);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxgb4i: Add a missing call to neigh_release
2016-11-19 17:42 [PATCH] cxgb4i: Add a missing call to neigh_release Quentin Lambert
@ 2016-11-29 16:48 ` Martin K. Petersen
2016-11-30 11:19 ` Varun Prakash
2016-11-30 16:37 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2016-11-29 16:48 UTC (permalink / raw)
To: Varun Prakash
Cc: Quentin Lambert, Karen Xie, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel, kernel-janitors
>>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:
Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.
Varun: Please review!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxgb4i: Add a missing call to neigh_release
2016-11-29 16:48 ` Martin K. Petersen
@ 2016-11-30 11:19 ` Varun Prakash
0 siblings, 0 replies; 4+ messages in thread
From: Varun Prakash @ 2016-11-30 11:19 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Quentin Lambert, Karen Xie, James E.J. Bottomley,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
On Tue, Nov 29, 2016 at 10:18:09PM +0530, Martin K. Petersen wrote:
> >>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:
>
> Quentin> Most error branches following the call to dst_neigh_lookup
> Quentin> contain a call to neigh_release. This patch add these calls
> Quentin> where they are missing.
>
> Varun: Please review!
>
Looks good.
Acked-by: Varun Prakash <varun@chelsio.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxgb4i: Add a missing call to neigh_release
2016-11-19 17:42 [PATCH] cxgb4i: Add a missing call to neigh_release Quentin Lambert
2016-11-29 16:48 ` Martin K. Petersen
@ 2016-11-30 16:37 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2016-11-30 16:37 UTC (permalink / raw)
To: Quentin Lambert
Cc: Varun Prakash, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel, kernel-janitors
>>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:
Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-30 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-19 17:42 [PATCH] cxgb4i: Add a missing call to neigh_release Quentin Lambert
2016-11-29 16:48 ` Martin K. Petersen
2016-11-30 11:19 ` Varun Prakash
2016-11-30 16:37 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).