linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] isci: Add a missing call to pci_unmap_biosrom
@ 2016-11-19 17:43 Quentin Lambert
  2016-11-29 16:50 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Quentin Lambert @ 2016-11-19 17:43 UTC (permalink / raw)
  To: Intel SCU Linux support, Artur Paszkiewicz, James E.J. Bottomley,
	Martin K. Petersen, linux-scsi, linux-kernel, kernel-janitors
  Cc: Quentin Lambert

Most error branches following the call to pci_map_biosrom contain
a call to pci_unmap_biosrom. This patch add these calls where
they are missing.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>

---
 drivers/scsi/isci/probe_roms.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/scsi/isci/probe_roms.c
+++ b/drivers/scsi/isci/probe_roms.c
@@ -54,6 +54,7 @@ struct isci_orom *isci_request_oprom(str
 	len = pci_biosrom_size(pdev);
 	rom = devm_kzalloc(&pdev->dev, sizeof(*rom), GFP_KERNEL);
 	if (!rom) {
+		pci_unmap_biosrom(oprom);
 		dev_warn(&pdev->dev,
 			 "Unable to allocate memory for orom\n");
 		return NULL;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-29 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-19 17:43 [PATCH] isci: Add a missing call to pci_unmap_biosrom Quentin Lambert
2016-11-29 16:50 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).