From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Thumshirn <jth@kernel.org>, Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
fcoe-devel@open-fcoe.org, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] scsi: libfc: Remove an unneeded condition
Date: Thu, 24 Nov 2016 13:52:38 +0300 [thread overview]
Message-ID: <20161124105238.GB17225@mwanda> (raw)
We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need
to check again here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 110a707..c991f3b 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -1196,7 +1196,6 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp,
* Check if the image pair could be established
*/
if (rdata->spp_type != FC_TYPE_FCP ||
- resp_code != FC_SPP_RESP_ACK ||
!(pp->spp.spp_flags & FC_SPP_EST_IMG_PAIR)) {
/*
* Nope; we can't use this port as a target.
next reply other threads:[~2016-11-24 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 10:52 Dan Carpenter [this message]
2016-11-25 8:59 ` [patch] scsi: libfc: Remove an unneeded condition Johannes Thumshirn
2016-11-25 15:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124105238.GB17225@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fcoe-devel@open-fcoe.org \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jth@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox