From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.
Date: Mon, 5 Dec 2016 04:59:08 -0800 [thread overview]
Message-ID: <20161205125908.GC23221@infradead.org> (raw)
In-Reply-To: <64bf8c12-c086-2531-8510-27a95f8f0ef1@suse.de>
[Hannes, can you please stop the damn full quotes? reading your answers
is a major pain]
> Have you modified the irq affinity for this?
> Typically the irq-affinity changes will treat all vectors identically,
> and spread them out across the available CPUS.
> But with this layout vector '0' apparently is the MB irq vector, and as
> such should _not_ be treated like the others wrt irq affinity, but
> rather left alone.
> Christoph put in some changes for that, but they'll be coming in via the
> tip tree, so not sure if Martin has already taken them in.
> But in either way, you should be using them to get the irq affinity
> layout correctly.
The changes are here:
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?h=irq/for-block
I don't think they are in the SCSI tree yet as I haven't gotten a reply
to the lpfc conversion yet. But that conversion is here for reference:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/lpfc-msix
qla2xxx would need to use pre_vectors instead of post_vectors, though.
next prev parent reply other threads:[~2016-12-05 12:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 21:44 [PATCH v3 0/6] qla2xxx: Feture updates for driver Himanshu Madhani
2016-12-02 21:44 ` [PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET Himanshu Madhani
2016-12-05 16:01 ` Christoph Hellwig
2016-12-05 18:36 ` Madhani, Himanshu
2016-12-06 13:57 ` Christoph Hellwig
2016-12-02 21:44 ` [PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation Himanshu Madhani
2016-12-05 16:03 ` Christoph Hellwig
2016-12-05 18:37 ` Madhani, Himanshu
2016-12-07 18:49 ` Christoph Hellwig
2016-12-02 21:44 ` [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls Himanshu Madhani
2016-12-05 7:19 ` Hannes Reinecke
2016-12-05 12:54 ` Christoph Hellwig
2016-12-05 16:09 ` Christoph Hellwig
2016-12-05 12:55 ` Christoph Hellwig
2016-12-05 21:20 ` Madhani, Himanshu
2016-12-02 21:44 ` [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality Himanshu Madhani
2016-12-05 7:38 ` Hannes Reinecke
2016-12-05 12:59 ` Christoph Hellwig [this message]
2016-12-05 20:43 ` Madhani, Himanshu
2016-12-05 22:08 ` Madhani, Himanshu
2016-12-05 16:20 ` Christoph Hellwig
2016-12-05 22:41 ` Madhani, Himanshu
2016-12-02 21:44 ` [PATCH v3 5/6] qla2xxx: Add Block Multi Queue functionality Himanshu Madhani
2016-12-05 7:39 ` Hannes Reinecke
2016-12-02 21:44 ` [PATCH v3 6/6] qla2xxx: Fix Target mode handling with Multiqueue changes Himanshu Madhani
2016-12-05 7:42 ` Hannes Reinecke
2016-12-05 21:06 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205125908.GC23221@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).