From: Christoph Hellwig <hch@infradead.org>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: target-devel@vger.kernel.org, nab@linux-iscsi.org,
giridhar.malavali@cavium.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency
Date: Wed, 14 Dec 2016 13:18:23 -0800 [thread overview]
Message-ID: <20161214211823.GC14133@infradead.org> (raw)
In-Reply-To: <1481056251-2310-9-git-send-email-himanshu.madhani@cavium.com>
- the new qla2x00_free_fcport is entirely pointless, please drop
that part of the patch (and even if it wasn't pointless it should
have been a patch on it's own)
- please use struct names and not typedefs for your new structures
- pretty much avery single items in your list should be a separate
patch. And some of them are actively counterproductive and should
be dropped:
- Remove direct access of scsi_status field in se_cmd
- Remove se_cmd from qlt_do_ctio_completion
- Remove se_cmd access in srr code section
- Move se_cmd struct outside of qla_tgt_cmd/qla_tgt_mgmt_cmd.
next prev parent reply other threads:[~2016-12-14 21:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 20:30 [PATCH 00/22] qla2xxx: Target code enhancemets and feature update Himanshu Madhani
2016-12-06 20:30 ` [PATCH 01/22] qla2xxx: Fix wrong IOCB type assumption Himanshu Madhani
2016-12-14 21:09 ` Christoph Hellwig
2016-12-15 17:20 ` Madhani, Himanshu
2016-12-06 20:30 ` [PATCH 02/22] qla2xxx: Include ATIO queue in firmware dump when in target mode Himanshu Madhani
2016-12-06 20:30 ` [PATCH 03/22] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version Himanshu Madhani
2016-12-14 21:12 ` Christoph Hellwig
2016-12-15 17:20 ` Madhani, Himanshu
2016-12-06 20:30 ` [PATCH 04/22] qla2xxx: Clear BIT 15 in NVRAM during initialization Himanshu Madhani
2016-12-06 20:30 ` [PATCH 05/22] qla2xxx: Add DebugFS node of irq vector cpuid Himanshu Madhani
2016-12-14 21:13 ` Christoph Hellwig
2016-12-15 19:32 ` Madhani, Himanshu
2016-12-06 20:30 ` [PATCH 06/22] qla2xxx: Collect addtional debug data for FW Himanshu Madhani
2016-12-06 20:30 ` [PATCH 07/22] qla2xxx: Fix crash due to null pointer access Himanshu Madhani
2016-12-06 20:30 ` [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency Himanshu Madhani
2016-12-14 21:18 ` Christoph Hellwig [this message]
2016-12-15 19:29 ` Madhani, Himanshu
2016-12-15 20:50 ` Tran, Quinn
2016-12-16 8:17 ` Christoph Hellwig
2016-12-16 8:49 ` Bart Van Assche
2016-12-06 20:30 ` [PATCH 09/22] qla2xxx: Refactor T10-DIF PI support Himanshu Madhani
2016-12-14 21:03 ` Christoph Hellwig
2016-12-06 20:30 ` [PATCH 10/22] qla2xxx: Add framework for Async fabric discovery Himanshu Madhani
2016-12-06 20:30 ` [PATCH 11/22] qla2xxx: Refactor session management code Himanshu Madhani
2016-12-14 21:04 ` Christoph Hellwig
2016-12-06 20:30 ` [PATCH 12/22] qla2xxx: Add Dual mode support in the driver Himanshu Madhani
2016-12-06 20:30 ` [PATCH 13/22] qla2xxx: Fix invalid handle erroneous message Himanshu Madhani
2016-12-06 20:30 ` [PATCH 14/22] qla2xxx: Add interrupt polling mechanism Himanshu Madhani
2016-12-14 21:06 ` Christoph Hellwig
2016-12-15 9:27 ` Bart Van Assche
2016-12-15 17:12 ` Madhani, Himanshu
2016-12-06 20:30 ` [PATCH 15/22] qla2xxx: Rename qlini_mode parameter Himanshu Madhani
2016-12-14 21:07 ` Christoph Hellwig
2016-12-15 17:21 ` Madhani, Himanshu
2016-12-06 20:30 ` [PATCH 16/22] qla2xxx: Improve RSCN handling in driver Himanshu Madhani
2016-12-07 11:32 ` Hannes Reinecke
2016-12-09 19:38 ` Madhani, Himanshu
2016-12-06 20:30 ` [PATCH 17/22] qla2xxx: Rerfactor use of sp context Himanshu Madhani
2016-12-06 20:30 ` [PATCH 18/22] qla2xxx: Fix slow mem alloc behind lock Himanshu Madhani
2016-12-06 20:30 ` [PATCH 19/22] qla2xxx: Reduce exess wait during chip reset Himanshu Madhani
2016-12-06 20:30 ` [PATCH 20/22] qla2xxx: Allow relogin to go through if remote login did not finish Himanshu Madhani
2016-12-07 12:05 ` Hannes Reinecke
2016-12-06 20:30 ` [PATCH 21/22] qla2xxx: Improve submission of non critical MB interface Himanshu Madhani
2016-12-07 12:16 ` Hannes Reinecke
2016-12-06 20:30 ` [PATCH 22/22] qla2xxx: Add check for corrupt ATIO Himanshu Madhani
2016-12-07 12:25 ` Hannes Reinecke
2016-12-12 23:10 ` [PATCH 00/22] qla2xxx: Target code enhancemets and feature update Madhani, Himanshu
2016-12-14 20:24 ` Madhani, Himanshu
2016-12-14 21:19 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-01-17 17:44 [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency Dr. Greg Wettstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214211823.GC14133@infradead.org \
--to=hch@infradead.org \
--cc=giridhar.malavali@cavium.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).