From: Christoph Hellwig <hch@infradead.org>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: target-devel@vger.kernel.org, bart.vanassche@gmail.com,
hch@infradead.org, nab@linux-iscsi.org,
giridhar.malavali@cavium.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 8/9] qla2xxx: Add T10-DIF opcode/type in qla_tgt_cmd
Date: Sun, 18 Dec 2016 01:52:15 -0800 [thread overview]
Message-ID: <20161218095215.GF23338@infradead.org> (raw)
In-Reply-To: <1482051769-22941-9-git-send-email-himanshu.madhani@cavium.com>
NAK again, duplicating fields in a common structure in a
driver-specific one is an absolute anti-pattern.
next prev parent reply other threads:[~2016-12-18 9:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 9:02 [PATCH 0/9] qla2xxx: Cleanup for target code Himanshu Madhani
2016-12-18 9:02 ` [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS Himanshu Madhani
2016-12-19 15:33 ` Bart Van Assche
2016-12-19 15:59 ` hch
2016-12-19 16:29 ` Bart Van Assche
2016-12-20 14:16 ` hch
2016-12-18 9:02 ` [PATCH 2/9] qla2xxx: Cleanup TMF code translation from qla_target Himanshu Madhani
2016-12-18 9:54 ` Christoph Hellwig
2016-12-18 9:02 ` [PATCH 3/9] qla2xxx: Move percpu_ida_{alloc|free} to tcm_qla2xxx Himanshu Madhani
2016-12-18 9:49 ` Christoph Hellwig
2016-12-18 9:02 ` [PATCH 4/9] qla2xxx: Cleanup for sess_kref handling Himanshu Madhani
2016-12-18 9:49 ` Christoph Hellwig
2016-12-18 9:02 ` [PATCH 5/9] qla2xxx: Move Command residual check from qla2xxx to tcm_qla2xxx Himanshu Madhani
2016-12-18 9:51 ` Christoph Hellwig
2016-12-18 9:02 ` [PATCH 6/9] qla2xxx: Remove direct access of scsi_status field in se_cmd Himanshu Madhani
2016-12-18 9:55 ` Christoph Hellwig
2016-12-18 9:02 ` [PATCH 7/9] qla2xxx: Remove direct access to t_task_cdb/t_task_lba field Himanshu Madhani
2016-12-18 9:51 ` Christoph Hellwig
2016-12-18 9:02 ` [PATCH 8/9] qla2xxx: Add T10-DIF opcode/type in qla_tgt_cmd Himanshu Madhani
2016-12-18 9:52 ` Christoph Hellwig [this message]
2016-12-18 9:02 ` [PATCH 9/9] qla2xxx: Remove se_cmd struct out of qla_tgt_cmd/qla_tgt_mgmt_cmd Himanshu Madhani
2016-12-18 9:53 ` Christoph Hellwig
2016-12-18 9:48 ` [PATCH 0/9] qla2xxx: Cleanup for target code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161218095215.GF23338@infradead.org \
--to=hch@infradead.org \
--cc=bart.vanassche@gmail.com \
--cc=giridhar.malavali@cavium.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).