From: Christoph Hellwig <hch@infradead.org>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: target-devel@vger.kernel.org, bart.vanassche@gmail.com,
hch@infradead.org, nab@linux-iscsi.org,
giridhar.malavali@cavium.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 07/10] qla2xxx: Terminate exchange if corrputed.
Date: Tue, 20 Dec 2016 06:13:43 -0800 [thread overview]
Message-ID: <20161220141343.GG16487@infradead.org> (raw)
In-Reply-To: <1482208424-12358-8-git-send-email-himanshu.madhani@cavium.com>
> + while ((ha->tgt.atio_ring_ptr->signature != ATIO_PROCESSED) ||
> + FCPCMD_IS_CORRUPTED(ha->tgt.atio_ring_ptr)) {
No need for the inner braces.
> +#define FCPCMD_IS_CORRUPTED(_a) \
> + ((_a->entry_type == ATIO_TYPE7) && \
> + ((le16_to_cpu(_a->attr_n_length) & FCP_CMD_LENTH_MASK) < \
> + FCP_CMD_LENTH_MIN))
> +
> +/* adjust corrupted atio so we won't trip over the same entry again. */
> +#define ADJ_CORRUPTED_ATIO(_a) \
> +{ \
> + _a->u.raw.attr_n_length = cpu_to_le16(FCP_CMD_LENTH_MIN); \
> + ((struct atio_from_isp *)_a)->u.isp24.fcp_cmnd.add_cdb_len = 0; \
> +}
These should be inline functions instead of macros.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-12-20 14:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 4:33 [PATCH 00/10] qla2xxx: Bug fixes for driver Himanshu Madhani
2016-12-20 4:33 ` [PATCH 01/10] qla2xxx: Fix wrong IOCB type assumption Himanshu Madhani
2016-12-20 14:10 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode Himanshu Madhani
2016-12-20 14:10 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 03/10] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version Himanshu Madhani
2016-12-20 14:11 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 04/10] qla2xxx: Reset reserved field in firmware options to 0 Himanshu Madhani
2016-12-20 14:11 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 05/10] qla2xxx: Collect additional information to debug fw dump Himanshu Madhani
2016-12-20 14:11 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 06/10] qla2xxx: Fix crash due to null pointer access Himanshu Madhani
2016-12-20 14:12 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 07/10] qla2xxx: Terminate exchange if corrputed Himanshu Madhani
2016-12-20 14:13 ` Christoph Hellwig [this message]
2016-12-20 4:33 ` [PATCH 08/10] qla2xxx: Reduce exess wait during chip reset Himanshu Madhani
2016-12-20 14:14 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 09/10] qla2xxx: Fix invalid handle erroneous message Himanshu Madhani
2016-12-20 14:15 ` Christoph Hellwig
2016-12-20 4:33 ` [PATCH 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware Himanshu Madhani
2016-12-20 14:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220141343.GG16487@infradead.org \
--to=hch@infradead.org \
--cc=bart.vanassche@gmail.com \
--cc=giridhar.malavali@cavium.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).