From: Christoph Hellwig <hch@infradead.org>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: target-devel@vger.kernel.org, bart.vanassche@gmail.com,
hch@infradead.org, nab@linux-iscsi.org,
giridhar.malavali@cavium.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 07/11] qla2xxx: Track I-T nexus as single fc_port struct.
Date: Mon, 9 Jan 2017 05:28:28 -0800 [thread overview]
Message-ID: <20170109132828.GE4438@infradead.org> (raw)
In-Reply-To: <1482553419-4117-8-git-send-email-himanshu.madhani@cavium.com>
> +typedef struct {
> + struct list_head list;
> + u8 iocb[64]; /* imm_ntfy_from_isp */
Please keep it as struct imm_ntfy_from_isp so that all the crazy
casts in the new code can be removed.
> + qlt_plogi_ack_t* plogi_link[QLT_PLOGI_LINK_MAX];
qlt_plogi_ack_t *plogi_link[QLT_PLOGI_LINK_MAX];
> + if (con)
> + {
if (con) {
> spin_lock_irqsave(&ha->tgt.sess_lock, flags);
> + ha->tgt.tgt_ops->put_sess(sess);
> spin_unlock_irqrestore(&ha->tgt.sess_lock, flags);
This pattern happens a lot and should probably be factored into a
helper.
> + struct fc_port *sess = container_of(kref,
> + struct fc_port, sess_kref);
This can fit into a single line:
struct fc_port *sess = container_of(kref, struct fc_port, sess_kref);
next prev parent reply other threads:[~2017-01-09 13:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 4:23 [PATCH 00/11] qla2xxx: Feature updates for target Himanshu Madhani
2016-12-24 4:23 ` [PATCH 01/11] qla2xxx: Remove direct access of scsi_status field in se_cmd Himanshu Madhani
2016-12-24 4:23 ` [PATCH 02/11] qla2xxx: Cleanup TMF code translation from qla_target Himanshu Madhani
2017-01-11 20:05 ` Bart Van Assche
2017-01-11 20:43 ` Madhani, Himanshu
2017-01-11 21:08 ` Bart Van Assche
2017-01-11 23:01 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 03/11] qla2xxx: Make trace flags more readable Himanshu Madhani
2017-01-09 13:11 ` Christoph Hellwig
2017-01-09 18:36 ` Madhani, Himanshu
2017-01-11 20:47 ` Bart Van Assche
2017-01-11 20:54 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 04/11] qla2xxx: Cleanup SRR code Himanshu Madhani
2017-01-09 13:13 ` Christoph Hellwig
2017-01-10 17:55 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 05/11] qla2xxx: Fix wrong argument in sp done callback Himanshu Madhani
2017-01-09 13:17 ` Christoph Hellwig
2017-01-09 18:05 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 06/11] qla2xxx: Use d_id instead of s_id for more clarity Himanshu Madhani
2017-01-09 13:17 ` Christoph Hellwig
2016-12-24 4:23 ` [PATCH 07/11] qla2xxx: Track I-T nexus as single fc_port struct Himanshu Madhani
2017-01-09 13:28 ` Christoph Hellwig [this message]
2016-12-24 4:23 ` [PATCH 08/11] qla2xxx: Add framework for Async fabric discovery Himanshu Madhani
2017-01-11 20:08 ` Bart Van Assche
2017-01-13 17:50 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 09/11] qla2xxx: Add Dual mode support in the driver Himanshu Madhani
2017-01-11 19:51 ` Bart Van Assche
2017-01-13 22:13 ` Madhani, Himanshu
2016-12-24 4:23 ` [PATCH 10/11] qla2xxx: Remove unused reverse_ini_mode Himanshu Madhani
2016-12-24 4:23 ` [PATCH 11/11] qla2xxx: Improve RSCN handling in driver Himanshu Madhani
2017-01-11 21:05 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109132828.GE4438@infradead.org \
--to=hch@infradead.org \
--cc=bart.vanassche@gmail.com \
--cc=giridhar.malavali@cavium.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox