From: "Pali Rohár" <pali.rohar@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
"Dainius Masiliūnas" <pastas4@gmail.com>,
"SCSI development list" <linux-scsi@vger.kernel.org>,
"USB list" <linux-usb@vger.kernel.org>,
"Tom Yan" <tom.ty89@gmail.com>
Subject: Re: Advanced Format SAT devices show incorrect physical block size
Date: Wed, 11 Jan 2017 14:33:17 +0100 [thread overview]
Message-ID: <20170111133317.GA31565@pali> (raw)
In-Reply-To: <1484086345.2518.9.camel@HansenPartnership.com>
On Tuesday 10 January 2017 14:12:25 James Bottomley wrote:
> On Tue, 2017-01-10 at 16:00 -0500, Alan Stern wrote:
> > In theory, I suppose we could change the kernel so that it would
> > default to READ CAPACITY(16) for devices that report a SCSI level >=
> > 3, or something along those lines. In general we hesitate to make
> > changes of this sort, because they almost always end up breaking
> > _some_ devices -- and if that happens then the change is reverted,
> > with no exceptions. Linus has a very strict rule about not breaking
> > working systems.
>
> You shouldn't have to change anything: it already does (otherwise how
> else would we detect physical exponent for proper SCSI devices) see
> sd.c:sd_try_rc16_first(). It always returns false for USB because you
> set sdev->try_rc_10_first
So.. what does it mean? Can we enable READ CAPACITY(16) for some USB
devices?
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-01-11 13:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201701102031.42361@pali>
2017-01-10 20:02 ` Advanced Format SAT devices show incorrect physical block size Alan Stern
2017-01-10 20:09 ` Dainius Masiliūnas
2017-01-10 20:29 ` Alan Stern
2017-01-10 20:44 ` Dainius Masiliūnas
[not found] ` <CABhjJhOp1GB0KXupWhDh-5v-+6N8=qA=rE9L21AANhdN5C0Bxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-10 21:00 ` Alan Stern
2017-01-10 21:42 ` Dainius Masiliūnas
2017-01-11 14:54 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1701101551591.2462-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-01-10 22:12 ` James Bottomley
2017-01-11 13:33 ` Pali Rohár [this message]
2017-01-11 15:23 ` Alan Stern
2017-01-29 17:18 ` Pali Rohár
2017-01-30 16:17 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1701301055100.2025-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-01-30 17:43 ` Pali Rohár
2017-02-23 9:03 ` Pali Rohár
[not found] ` <Pine.LNX.4.44L0.1701101520510.2462-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-01-11 13:36 ` Pali Rohár
2017-01-11 15:10 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1701101457390.2462-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-01-10 20:12 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111133317.GA31565@pali \
--to=pali.rohar@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pastas4@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox