From: Dan Carpenter <dan.carpenter@oracle.com>
To: sasikumar.pc@broadcom.com, Tomas Henzl <thenzl@redhat.com>
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: [bug report] scsi: megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers
Date: Thu, 12 Jan 2017 22:09:16 +0300 [thread overview]
Message-ID: <20170112190916.GA14816@mwanda> (raw)
Hello Sasikumar Chandrasekaran,
The patch d889344e4e59: "scsi: megaraid_sas: Dynamic Raid Map Changes
for SAS3.5 Generic Megaraid Controllers" from Jan 10, 2017, leads to
the following static checker warning:
drivers/scsi/megaraid/megaraid_sas_fusion.c:2043 megasas_build_ldio_fusion()
warn: curly braces intended?
drivers/scsi/megaraid/megaraid_sas_fusion.c
2020 if (instance->is_ventura) {
2021 if (io_info.isRead) {
2022 if ((raid->cpuAffinity.pdRead.cpu0) &&
2023 (raid->cpuAffinity.pdRead.cpu1))
2024 praid_context->raid_context_g35.routing_flags.bits.cpu_sel
2025 = MR_RAID_CTX_CPUSEL_FCFS;
2026 else if (raid->cpuAffinity.pdRead.cpu1)
2027 praid_context->raid_context_g35.routing_flags.bits.cpu_sel
2028 = MR_RAID_CTX_CPUSEL_1;
2029 else
2030 praid_context->raid_context_g35.routing_flags.bits.cpu_sel
2031 = MR_RAID_CTX_CPUSEL_0;
2032 } else {
2033 if ((raid->cpuAffinity.pdWrite.cpu0)
2034 && (raid->cpuAffinity.pdWrite.cpu1))
2035 praid_context->raid_context_g35.routing_flags.bits.cpu_sel
2036 = MR_RAID_CTX_CPUSEL_FCFS;
2037 else if (raid->cpuAffinity.pdWrite.cpu1)
2038 praid_context->raid_context_g35.routing_flags.bits.cpu_sel
2039 = MR_RAID_CTX_CPUSEL_1;
2040 else
2041 praid_context->raid_context_g35.routing_flags.bits.cpu_sel
2042 = MR_RAID_CTX_CPUSEL_0;
2043 if (praid_context->raid_context_g35.routing_flags.bits.sld) {
2044 praid_context->raid_context_g35.raid_flags
2045 = (MR_RAID_FLAGS_IO_SUB_TYPE_CACHE_BYPASS
2046 << MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT);
2047 }
2048 }
2049 }
2050 } else {
Wow... You guys are probably already discussed this code, but I'm not
on the linux-scsi list. Do we have a process issue where we are merging
code that we shouldn't be? What's going on here?
regards,
dan carpenter
next reply other threads:[~2017-01-12 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 19:09 Dan Carpenter [this message]
2017-01-13 19:52 ` [bug report] scsi: megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar PC
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112190916.GA14816@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=sasikumar.pc@broadcom.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox