From: Johannes Thumshirn <jthumshirn@suse.de>
To: James Smart <jsmart2021@gmail.com>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 04/17] lpfc: NVME Initiator: Base modifications Part C
Date: Thu, 19 Jan 2017 09:14:06 +0100 [thread overview]
Message-ID: <20170119081406.GD5054@linux-x5ow.site> (raw)
In-Reply-To: <784acc16-b284-6159-4399-dfd39ae1a8bd@gmail.com>
On Wed, Jan 18, 2017 at 06:54:37PM -0800, James Smart wrote:
>
>
> On 1/18/2017 3:03 AM, Johannes Thumshirn wrote:
> >
> >>+ /* maximum number of xris available for nvme buffers */
> >>+ els_xri_cnt = lpfc_sli4_get_els_iocb_cnt(phba);
> >>+ phba->sli4_hba.nvme_xri_max = phba->sli4_hba.max_cfg_param.max_xri -
> >>+ els_xri_cnt;
> >>+ phba->sli4_hba.nvme_xri_max -= phba->sli4_hba.scsi_xri_max;
> > nvme_xri_max = phba->sli4_hba.max_cfg_param.max_xri - els_xri_cnt;
> > nvme_xri_max -= phba->sli4_hba.scsi_xri_max;
> > phba->sli4_hba.nvme_xri_max = nvme_xri_max;
> >
> >Low hanging anti line-break fruit.
>
> ok - but I didn't think that a style change like this is a mandate. As I'm
> addressing your other comments, I'll do so.
I don't think it's a mandate, but line wrappings are always bad to read. Code
is written once but read a lot of times. I know I'm nitpicking a lot here but
hard to read code makes errors hard to spot.
Thanks for your patience,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2017-01-19 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 1:20 [PATCH 04/17] lpfc: NVME Initiator: Base modifications Part C James Smart
2017-01-18 7:17 ` Hannes Reinecke
2017-01-19 2:08 ` James Smart
2017-01-18 11:03 ` Johannes Thumshirn
2017-01-19 2:54 ` James Smart
2017-01-19 8:14 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119081406.GD5054@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).