From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH V2 04/24] aacraid: Added sa firmware support Date: Thu, 26 Jan 2017 09:55:16 +0100 Message-ID: <20170126085142.GF3591@linux-x5ow.site> References: <20170125180111.25401-1-RaghavaAditya.Renukunta@microsemi.com> <20170125180111.25401-5-RaghavaAditya.Renukunta@microsemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:36383 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863AbdAZIzX (ORCPT ); Thu, 26 Jan 2017 03:55:23 -0500 Content-Disposition: inline In-Reply-To: <20170125180111.25401-5-RaghavaAditya.Renukunta@microsemi.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Raghava Aditya Renukunta Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, David.Carroll@microsemi.com, Gana.Sridaran@microsemi.com, Scott.Benesh@microsemi.com On Wed, Jan 25, 2017 at 10:00:51AM -0800, Raghava Aditya Renukunta wrote: > sa_firmware adds the capability to differentiate the new SmartIOC family > of adapters from the series 8 and below. > > Signed-off-by: Raghava Aditya Renukunta > Signed-off-by: Dave Carroll > > --- [...] > @@ -465,9 +473,13 @@ void aac_define_int_mode(struct aac_dev *dev) > if (dev->max_msix > msi_count) > dev->max_msix = msi_count; > } > - dev->vector_cap = > - (dev->scsi_host_ptr->can_queue + AAC_NUM_MGT_FIB) / > - msi_count; > + if (dev->comm_interface == AAC_COMM_MESSAGE_TYPE3 && dev->sa_firmware) > + dev->vector_cap = (dev->scsi_host_ptr->can_queue + > + AAC_NUM_MGT_FIB); '+' has precedence before '=' and you do no multiplication here, so no brackets needed. [...] -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850