From: Stephen Hemminger <stephen@networkplumber.org>
To: Christoph Hellwig <hch@lst.de>
Cc: KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] storvsc: remove bogus code to transfer struct scatterlist
Date: Mon, 30 Jan 2017 16:00:16 -0800 [thread overview]
Message-ID: <20170130160016.2da37993@xeon-e3> (raw)
In-Reply-To: <1485681138-21236-1-git-send-email-hch@lst.de>
On Sun, 29 Jan 2017 01:12:18 -0800
"Christoph Hellwig" <hch@lst.de> wrote:
> Remove a piece of code in storvsc_queuecommand that tries to pass the
> physical address of the kernel struct scatterlist pointer to the host.
>
> Fortunately the code can't ever be reached anyway.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/scsi/storvsc_drv.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 05526b7..62f4545 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1511,13 +1511,6 @@ static int storvsc_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *scmnd)
> page_to_pfn(sg_page((cur_sgl)));
> cur_sgl = sg_next(cur_sgl);
> }
> -
> - } else if (scsi_sglist(scmnd)) {
> - payload->range.len = length;
> - payload->range.offset =
> - virt_to_phys(scsi_sglist(scmnd)) & (PAGE_SIZE-1);
> - payload->range.pfn_array[0] =
> - virt_to_phys(scsi_sglist(scmnd)) >> PAGE_SHIFT;
> }
>
> cmd_request->payload = payload;
Looks like something that has been around from first versions of hyper-v support.
next prev parent reply other threads:[~2017-01-31 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 9:12 [PATCH] storvsc: remove bogus code to transfer struct scatterlist Christoph Hellwig
2017-01-30 17:19 ` Bart Van Assche
2017-01-30 23:48 ` KY Srinivasan
2017-01-31 0:00 ` Stephen Hemminger [this message]
2017-02-01 2:49 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130160016.2da37993@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=haiyangz@microsoft.com \
--cc=hch@lst.de \
--cc=kys@microsoft.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox