From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Omar Sandoval <osandov@osandov.com>
Subject: Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes
Date: Wed, 1 Feb 2017 09:07:36 +0100 [thread overview]
Message-ID: <20170201080736.GA29170@lst.de> (raw)
In-Reply-To: <CAPcyv4jJ5VMNueBTkYhTS=DmAQVDT6qJV0Do86ZNVGLGoTJ=gQ@mail.gmail.com>
On Mon, Jan 30, 2017 at 01:53:36PM -0800, Dan Williams wrote:
> On Mon, Jan 30, 2017 at 4:24 AM, Christoph Hellwig <hch@lst.de> wrote:
> > Hi Dan,
> >
> > this looks mostly fine to me. A few code comments below, but except
> > for this there is another issue with it: We still have drivers
> > that share a single request_queue for multiple gendisks, so I wonder
>
> scsi drivers or others? If those drivers can switch to dynamically
> allocated devt (GENHD_FL_EXT_DEVT), then they don't need this fix.
Mostly old floppy drivers.
prev parent reply other threads:[~2017-02-01 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 4:58 [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes Dan Williams
2017-01-30 7:05 ` Hannes Reinecke
2017-01-30 7:22 ` Omar Sandoval
2017-01-30 7:46 ` Dan Williams
2017-01-30 12:24 ` Christoph Hellwig
2017-01-30 20:57 ` Dan Williams
2017-02-01 8:08 ` Christoph Hellwig
2017-01-30 21:53 ` Dan Williams
2017-02-01 8:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201080736.GA29170@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=dan.j.williams@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).