public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Derek Chickles <derek.chickles@caviumnetworks.com>,
	Felix Manlunas <felix.manlunas@caviumnetworks.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Jiri Slaby <jirislaby@gmail.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Raghu Vatsavayi <raghu.vatsavay>
Subject: [PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes
Date: Tue,  7 Feb 2017 15:03:05 -0800	[thread overview]
Message-ID: <20170207230305.18222-13-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

From: Russell King <rmk+kernel@armlinux.org.uk>

Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
unnecessary dependency for quite a large amount of the kernel.  There's
very little which actually requires definitions from phy.h in net/dsa.h
- the include itself only wants the declaration of a couple of
structures and IFNAMSIZ.

Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
and phy_fixed.h from net/dsa.h.

This patch reduces from around 800 files rebuilt to around 40 - even
with ccache, the time difference is noticable.

Tested-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
 include/net/dsa.h                     | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
index 8a21800374f3..91c4dd25c2d3 100644
--- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
+++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
@@ -15,6 +15,7 @@
 #include <linux/if_vlan.h>
 #include <linux/irq.h>
 #include <linux/gpio/consumer.h>
+#include <linux/phy.h>
 
 #ifndef UINT64_MAX
 #define UINT64_MAX		(u64)(~((u64)0))
diff --git a/include/net/dsa.h b/include/net/dsa.h
index b49b2004891e..4e13e695f025 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -11,17 +11,18 @@
 #ifndef __LINUX_NET_DSA_H
 #define __LINUX_NET_DSA_H
 
+#include <linux/if.h>
 #include <linux/if_ether.h>
 #include <linux/list.h>
 #include <linux/notifier.h>
 #include <linux/timer.h>
 #include <linux/workqueue.h>
 #include <linux/of.h>
-#include <linux/phy.h>
-#include <linux/phy_fixed.h>
 #include <linux/ethtool.h>
 
 struct tc_action;
+struct phy_device;
+struct fixed_phy_status;
 
 enum dsa_tag_protocol {
 	DSA_TAG_PROTO_NONE = 0,
-- 
2.9.3

  parent reply	other threads:[~2017-02-07 23:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 23:02 [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 02/12] net: cgroups: " Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 03/12] net: macb: " Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 04/12] net: lan78xx: " Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 05/12] net: bgmac: " Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 07/12] net: mvneta: " Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*() Florian Fainelli
     [not found] ` <20170207230305.18222-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-07 23:02   ` [PATCH net-next v2 06/12] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:03   ` [PATCH net-next v2 08/12] iscsi: " Florian Fainelli
2017-02-08  4:53     ` Nicholas A. Bellinger
2017-02-07 23:03   ` [PATCH net-next v2 10/12] net: liquidio: " Florian Fainelli
2017-02-07 23:03   ` [PATCH net-next v2 11/12] net: ath5k: " Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli [this message]
2017-02-08 16:06 ` [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include David Miller
2017-02-08 16:11   ` Kalle Valo
2017-02-08 19:45     ` Florian Fainelli
2017-02-09 14:10       ` Kalle Valo
2017-02-10 18:51         ` David Miller
2017-02-10 19:44           ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207230305.18222-13-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=davem@davemloft.net \
    --cc=derek.chickles@caviumnetworks.com \
    --cc=felix.manlunas@caviumnetworks.com \
    --cc=jirislaby@gmail.com \
    --cc=jlayton@poochiereds.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=mcgrof@do-not-panic.com \
    --cc=mickflemm@gmail.com \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox