From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, linux-mips@linux-mips.org,
linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
target-devel@vger.kernel.org
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Anna Schumaker <anna.schumaker@netapp.com>,
"David S. Miller" <davem@davemloft.net>,
Derek Chickles <derek.chickles@caviumnetworks.com>,
Felix Manlunas <felix.manlunas@caviumnetworks.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>,
Jiri Slaby <jirislaby@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Raghu Vatsavayi <raghu.vatsavay>
Subject: [PATCH net-next v2 05/12] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h
Date: Tue, 7 Feb 2017 15:02:58 -0800 [thread overview]
Message-ID: <20170207230305.18222-6-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>
From: Russell King <rmk+kernel@armlinux.org.uk>
drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus'
drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1198:2: error: implicit declaration of function 'phy_stop' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1239:9: error: implicit declaration of function 'phy_mii_ioctl' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1389:28: error: 'phy_ethtool_get_link_ksettings' undeclared here (not in a function)
drivers/net/ethernet/broadcom/bgmac.c:1390:28: error: 'phy_ethtool_set_link_ksettings' undeclared here (not in a function)
drivers/net/ethernet/broadcom/bgmac.c:1403:13: error: dereferencing pointer to incomplete type 'struct phy_device'
drivers/net/ethernet/broadcom/bgmac.c:1417:3: error: implicit declaration of function 'phy_print_status' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1424:26: error: storage size of 'fphy_status' isn't known
drivers/net/ethernet/broadcom/bgmac.c:1424:9: error: variable 'fphy_status' has initializer but incomplete type
drivers/net/ethernet/broadcom/bgmac.c:1425:11: warning: excess elements in struct initializer
drivers/net/ethernet/broadcom/bgmac.c:1425:3: error: unknown field 'link' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1426:12: note: in expansion of macro 'SPEED_1000'
drivers/net/ethernet/broadcom/bgmac.c:1426:3: error: unknown field 'speed' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1427:13: note: in expansion of macro 'DUPLEX_FULL'
drivers/net/ethernet/broadcom/bgmac.c:1427:3: error: unknown field 'duplex' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1432:12: error: implicit declaration of function 'fixed_phy_register' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1432:31: error: 'PHY_POLL' undeclared (first use in this function)
drivers/net/ethernet/broadcom/bgmac.c:1438:8: error: implicit declaration of function 'phy_connect_direct' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1439:6: error: 'PHY_INTERFACE_MODE_MII' undeclared (first use in this function)
drivers/net/ethernet/broadcom/bgmac.c:1521:2: error: implicit declaration of function 'phy_disconnect' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1541:15: error: expected declaration specifiers or '...' before string constant
Add linux/phy.h to bgmac.c
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/net/ethernet/broadcom/bgmac.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index fe88126b1e0c..20fe2520da42 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -12,6 +12,8 @@
#include <linux/bcma/bcma.h>
#include <linux/etherdevice.h>
#include <linux/bcm47xx_nvram.h>
+#include <linux/phy.h>
+#include <linux/phy_fixed.h>
#include "bgmac.h"
static bool bgmac_wait_value(struct bgmac *bgmac, u16 reg, u32 mask,
--
2.9.3
next prev parent reply other threads:[~2017-02-07 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:02 [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 02/12] net: cgroups: " Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 03/12] net: macb: " Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 04/12] net: lan78xx: " Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli [this message]
[not found] ` <20170207230305.18222-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-07 23:02 ` [PATCH net-next v2 06/12] net: fman: " Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 08/12] iscsi: " Florian Fainelli
2017-02-08 4:53 ` Nicholas A. Bellinger
2017-02-07 23:03 ` [PATCH net-next v2 10/12] net: liquidio: " Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 11/12] net: ath5k: " Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 07/12] net: mvneta: " Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*() Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes Florian Fainelli
2017-02-08 16:06 ` [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include David Miller
2017-02-08 16:11 ` Kalle Valo
2017-02-08 19:45 ` Florian Fainelli
2017-02-09 14:10 ` Kalle Valo
2017-02-10 18:51 ` David Miller
2017-02-10 19:44 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207230305.18222-6-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=jirislaby@gmail.com \
--cc=jlayton@poochiereds.net \
--cc=kvalo@codeaurora.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=mcgrof@do-not-panic.com \
--cc=mickflemm@gmail.com \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox