From: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: David.Carroll@microsemi.com, Gana.Sridaran@microsemi.com,
Scott.Benesh@microsemi.com, jthumshirn@suse.de,
dan.carpenter@oracle.com
Subject: [PATCH 02/16] aacraid: Use correct channel number for raw srb
Date: Tue, 14 Feb 2017 12:44:32 -0800 [thread overview]
Message-ID: <20170214204446.14808-3-RaghavaAditya.Renukunta@microsemi.com> (raw)
In-Reply-To: <20170214204446.14808-1-RaghavaAditya.Renukunta@microsemi.com>
The channel being used for raw srb commands is retrieved from the utility
sent fibs and is converted into physical channel id. The driver does not
need to to do this since the management utility sends the correct channel
id in the first place and in addition the driver sets inaccurate
information in the cmd sent to the firmware and gets an invalid response.
Fixed by using channel id from srb command.
Cc: stable@vger.kernel.org
Fixes: 423400e64d377c0 ("scsi: aacraid: Include HBA direct interface")
Signed-off-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Reviewed-by: David Carroll <David.Carroll@microsemi.com>
---
drivers/scsi/aacraid/commctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index 614842a..f6afd50 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -580,7 +580,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
goto cleanup;
}
- chn = aac_logical_to_phys(user_srbcmd->channel);
+ chn = user_srbcmd->channel;
if (chn < AAC_MAX_BUSES && user_srbcmd->id < AAC_MAX_TARGETS &&
dev->hba_map[chn][user_srbcmd->id].devtype ==
AAC_DEVTYPE_NATIVE_RAW) {
--
2.7.4
next prev parent reply other threads:[~2017-02-15 3:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 20:44 [PATCH 00/16] aacraid: Fixes and enhancements for arc family Raghava Aditya Renukunta
2017-02-14 20:44 ` [PATCH 01/16] aacraid: Fix camel case Raghava Aditya Renukunta
2017-02-15 8:02 ` Johannes Thumshirn
2017-02-14 20:44 ` Raghava Aditya Renukunta [this message]
2017-02-15 8:03 ` [PATCH 02/16] aacraid: Use correct channel number for raw srb Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 03/16] aacraid: Fix for excessive prints on EEH Raghava Aditya Renukunta
2017-02-15 8:07 ` Johannes Thumshirn
2017-02-15 18:06 ` Raghava Aditya Renukunta
2017-02-14 20:44 ` [PATCH 04/16] aacraid: Prevent E3 lockup when deleting units Raghava Aditya Renukunta
2017-02-15 8:20 ` Johannes Thumshirn
2017-02-15 18:08 ` Raghava Aditya Renukunta
2017-02-16 7:40 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 05/16] aacraid: Fix memory leak in fib init path Raghava Aditya Renukunta
2017-02-15 8:31 ` Johannes Thumshirn
2017-02-15 18:08 ` Raghava Aditya Renukunta
2017-02-14 20:44 ` [PATCH 06/16] aacraid: Added sysfs for driver version Raghava Aditya Renukunta
2017-02-15 8:32 ` Johannes Thumshirn
2017-02-15 18:12 ` Raghava Aditya Renukunta
2017-02-16 7:43 ` Johannes Thumshirn
2017-02-16 19:38 ` Raghava Aditya Renukunta
2017-02-14 20:44 ` [PATCH 07/16] aacraid: Fix sync fibs time out on controller reset Raghava Aditya Renukunta
2017-02-15 8:34 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 08/16] aacraid: Skip wellness sync on controller failure Raghava Aditya Renukunta
2017-02-15 8:35 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 09/16] aacraid: Reload offlined drives after controller reset Raghava Aditya Renukunta
2017-02-15 8:38 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 10/16] aacraid: Terminate kthread on controller fw assert Raghava Aditya Renukunta
2017-02-15 8:44 ` Johannes Thumshirn
2017-02-15 22:22 ` Raghava Aditya Renukunta
2017-02-16 9:31 ` Johannes Thumshirn
2017-02-16 19:53 ` Raghava Aditya Renukunta
2017-02-14 20:44 ` [PATCH 11/16] aacraid: Decrease adapter health check interval Raghava Aditya Renukunta
2017-02-15 8:45 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 12/16] aacraid: Skip IOP reset on controller panic(SMART Family) Raghava Aditya Renukunta
2017-02-15 8:49 ` Johannes Thumshirn
2017-02-15 18:14 ` Raghava Aditya Renukunta
2017-02-14 20:44 ` [PATCH 13/16] aacraid: Reorder Adapter status check Raghava Aditya Renukunta
2017-02-15 8:50 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 14/16] aacraid: Save adapter fib log before an IOP reset Raghava Aditya Renukunta
2017-02-15 8:53 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 15/16] aacraid: Fix a potential spinlock double unlock bug Raghava Aditya Renukunta
2017-02-15 8:54 ` Johannes Thumshirn
2017-02-14 20:44 ` [PATCH 16/16] aacraid: Update driver version Raghava Aditya Renukunta
2017-02-15 8:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214204446.14808-3-RaghavaAditya.Renukunta@microsemi.com \
--to=raghavaaditya.renukunta@microsemi.com \
--cc=David.Carroll@microsemi.com \
--cc=Gana.Sridaran@microsemi.com \
--cc=Scott.Benesh@microsemi.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox