From: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: David.Carroll@microsemi.com, Gana.Sridaran@microsemi.com,
Scott.Benesh@microsemi.com, jthumshirn@suse.de,
dan.carpenter@oracle.com
Subject: [PATCH V2 14/15] aacraid: Fix a potential spinlock double unlock bug
Date: Thu, 16 Feb 2017 12:51:23 -0800 [thread overview]
Message-ID: <20170216205124.20271-15-RaghavaAditya.Renukunta@microsemi.com> (raw)
In-Reply-To: <20170216205124.20271-1-RaghavaAditya.Renukunta@microsemi.com>
The driver does not unlock the reply queue spin lock after handling SMART
adapter events. Instead it might attempt to unlock an already unlocked
spin lock.
Fixed by making sure the driver locks the spin lock before freeing it.
Thank you dan for finding this issue out.
Fixes: 6223a39fe6fbbeef (scsi: aacraid: Added support for hotplug)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Reviewed-by: David Carroll <David.Carroll@microsemi.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
---
Changes in V2:
None
drivers/scsi/aacraid/commsup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 1f716c0..a2ea70d 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -2215,7 +2215,7 @@ static void aac_process_events(struct aac_dev *dev)
/* Thor AIF */
aac_handle_sa_aif(dev, fib);
aac_fib_adapter_complete(fib, (u16)sizeof(u32));
- continue;
+ goto free_fib;
}
/*
* We will process the FIB here or pass it to a
--
2.7.4
next prev parent reply other threads:[~2017-02-17 3:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 20:51 [PATCH V2 00/15] aacraid: Fixes and enhancements for arc family Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 01/15] aacraid: Fix camel case Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 02/15] aacraid: Use correct channel number for raw srb Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 03/15] aacraid: Fix for excessive prints on EEH Raghava Aditya Renukunta
2017-02-17 8:21 ` Johannes Thumshirn
2017-02-16 20:51 ` [PATCH V2 04/15] aacraid: Prevent E3 lockup when deleting units Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 05/15] aacraid: Fix memory leak in fib init path Raghava Aditya Renukunta
2017-02-17 8:22 ` Johannes Thumshirn
2017-02-16 20:51 ` [PATCH V2 06/15] aacraid: Added sysfs for driver version Raghava Aditya Renukunta
2017-02-17 8:22 ` Johannes Thumshirn
2017-02-16 20:51 ` [PATCH V2 07/15] aacraid: Fix sync fibs time out on controller reset Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 08/15] aacraid: Skip wellness sync on controller failure Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 09/15] aacraid: Reload offlined drives after controller reset Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 10/15] aacraid: Decrease adapter health check interval Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 11/15] aacraid: Skip IOP reset on controller panic(SMART Family) Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 12/15] aacraid: Reorder Adapter status check Raghava Aditya Renukunta
2017-02-16 20:51 ` [PATCH V2 13/15] aacraid: Save adapter fib log before an IOP reset Raghava Aditya Renukunta
2017-02-16 20:51 ` Raghava Aditya Renukunta [this message]
2017-02-16 20:51 ` [PATCH V2 15/15] aacraid: Update driver version Raghava Aditya Renukunta
2017-02-21 2:53 ` [PATCH V2 00/15] aacraid: Fixes and enhancements for arc family Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216205124.20271-15-RaghavaAditya.Renukunta@microsemi.com \
--to=raghavaaditya.renukunta@microsemi.com \
--cc=David.Carroll@microsemi.com \
--cc=Gana.Sridaran@microsemi.com \
--cc=Scott.Benesh@microsemi.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox