From: Dan Carpenter <dan.carpenter@oracle.com>
To: RaghavaAditya.Renukunta@microsemi.com
Cc: linux-scsi@vger.kernel.org
Subject: [bug report] scsi: aacraid: Reorder Adapter status check
Date: Mon, 27 Feb 2017 18:31:31 +0300 [thread overview]
Message-ID: <20170227153131.GA24809@mwanda> (raw)
Hello Raghava Aditya Renukunta,
The patch c421530bf848: "scsi: aacraid: Reorder Adapter status check"
from Feb 16, 2017, leads to the following static checker warning:
drivers/scsi/aacraid/src.c:471 aac_src_check_health()
warn: was shift intended here '(status > 16)'
drivers/scsi/aacraid/src.c
464 */
465 return 0;
466
467 err_out:
468 return -1;
469
470 err_blink:
471 return (status > 16) & 0xFF;
^^^^^^^^^^^^^^^^^^^
Issue #1: This is obviously a typo.
472 }
Issue #2: The caller checks for if the return is greater than 2. It
never is. We can remove this dead code.
Issue #3: The caller passes "bled" to aac_send_iop_reset() which
ignores it. What's up with that? Either it's a bug or we
should delete that dead code.
regards,
dan carpenter
next reply other threads:[~2017-02-27 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 15:31 Dan Carpenter [this message]
2017-03-02 19:39 ` [bug report] scsi: aacraid: Reorder Adapter status check Dave Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227153131.GA24809@mwanda \
--to=dan.carpenter@oracle.com \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox