* [bug report] scsi: lpfc: NVME Target: Base modifications
@ 2017-02-27 16:48 Dan Carpenter
2017-03-04 17:46 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-02-27 16:48 UTC (permalink / raw)
To: jsmart2021; +Cc: linux-scsi
Hello James Smart,
This is a semi-automatic email about new static checker warnings.
The patch f358dd0ca26c: "scsi: lpfc: NVME Target: Base modifications"
from Feb 12, 2017, leads to the following Smatch complaint:
drivers/scsi/lpfc/lpfc_mem.c:650 lpfc_sli4_nvmet_alloc()
warn: variable dereferenced before check 'dma_buf->iocbq' (see line 649)
drivers/scsi/lpfc/lpfc_mem.c
648 dma_buf->iocbq = lpfc_sli_get_iocbq(phba);
649 dma_buf->iocbq->iocb_flag = LPFC_IO_NVMET;
^^^^^^^^^^^^^^^^^^^^^^^^^
Dereference.
650 if (!dma_buf->iocbq) {
^^^^^^^^^^^^^^
Check.
651 kfree(dma_buf->context);
652 pci_pool_free(phba->lpfc_drb_pool, dma_buf->dbuf.virt,
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] scsi: lpfc: NVME Target: Base modifications
2017-02-27 16:48 [bug report] scsi: lpfc: NVME Target: Base modifications Dan Carpenter
@ 2017-03-04 17:46 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2017-03-04 17:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi
On 2/27/2017 8:48 AM, Dan Carpenter wrote:
> Hello James Smart,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch f358dd0ca26c: "scsi: lpfc: NVME Target: Base modifications"
> from Feb 12, 2017, leads to the following Smatch complaint:
>
>
Thanks. Issues were addressed by patch from Colin King, and pushed in
the lpfc patch set just posted.
see http://marc.info/?l=linux-scsi&m=148864866415099&w=2
-- james
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-04 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-27 16:48 [bug report] scsi: lpfc: NVME Target: Base modifications Dan Carpenter
2017-03-04 17:46 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox