public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Loïc Yhuel" <loic.yhuel@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Jim Gill <jgill@vmware.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [regression] vmw_pvscsi probe fails on 4.11
Date: Thu, 2 Mar 2017 17:05:53 +0100	[thread overview]
Message-ID: <20170302160553.GA4353@lst.de> (raw)
In-Reply-To: <cd383513-7fc2-5cec-9471-808e97bef27a@gmail.com>

Please try this patch:

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index ef474a748744..c374e3b5c678 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -1487,7 +1487,7 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		irq_flag &= ~PCI_IRQ_MSI;
 
 	error = pci_alloc_irq_vectors(adapter->dev, 1, 1, irq_flag);
-	if (error)
+	if (error < 0)
 		goto out_reset_adapter;
 
 	adapter->use_req_threshold = pvscsi_setup_req_threshold(adapter, true);

  reply	other threads:[~2017-03-02 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  8:51 [regression] vmw_pvscsi probe fails on 4.11 Loïc Yhuel
2017-03-02 16:05 ` Christoph Hellwig [this message]
2017-03-02 19:39   ` Loïc Yhuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302160553.GA4353@lst.de \
    --to=hch@lst.de \
    --cc=jgill@vmware.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loic.yhuel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox