* [PATCH] aacraid: Fix typo in blink status
@ 2017-03-02 17:21 Raghava Aditya Renukunta
2017-03-03 18:34 ` Dave Carroll
2017-03-07 3:24 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Raghava Aditya Renukunta @ 2017-03-02 17:21 UTC (permalink / raw)
To: jejb, martin.petersen, linux-scsi
Cc: David.Carroll, Gana.Sridaran, Scott.Benesh
The return status of the adapter check on KERNEL_PANIC is supposed
to be the upper 16 bits of the OMR status register.
Fixes: c421530bf848604e (scsi: aacraid: Reorder Adpater status check)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
---
drivers/scsi/aacraid/src.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 2e5338d..7b0410e 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -468,7 +468,7 @@ static int aac_src_check_health(struct aac_dev *dev)
return -1;
err_blink:
- return (status > 16) & 0xFF;
+ return (status >> 16) & 0xFF;
}
static inline u32 aac_get_vector(struct aac_dev *dev)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] aacraid: Fix typo in blink status
2017-03-02 17:21 [PATCH] aacraid: Fix typo in blink status Raghava Aditya Renukunta
@ 2017-03-03 18:34 ` Dave Carroll
2017-03-07 3:24 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Dave Carroll @ 2017-03-03 18:34 UTC (permalink / raw)
To: Raghava Aditya Renukunta, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Cc: Gana Sridaran, Scott Benesh
> Subject: [PATCH] aacraid: Fix typo in blink status
>
> The return status of the adapter check on KERNEL_PANIC is supposed to be
> the upper 16 bits of the OMR status register.
>
> Fixes: c421530bf848604e (scsi: aacraid: Reorder Adpater status check)
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Raghava Aditya Renukunta
> <RaghavaAditya.Renukunta@microsemi.com>
> ---
> drivers/scsi/aacraid/src.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Dave Carroll <david.carroll@microsemi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aacraid: Fix typo in blink status
2017-03-02 17:21 [PATCH] aacraid: Fix typo in blink status Raghava Aditya Renukunta
2017-03-03 18:34 ` Dave Carroll
@ 2017-03-07 3:24 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-03-07 3:24 UTC (permalink / raw)
To: Raghava Aditya Renukunta
Cc: jejb, martin.petersen, linux-scsi, David.Carroll, Gana.Sridaran,
Scott.Benesh
>>>>> "Raghava" == Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com> writes:
Raghava> The return status of the adapter check on KERNEL_PANIC is
Raghava> supposed to be the upper 16 bits of the OMR status register.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-07 3:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-02 17:21 [PATCH] aacraid: Fix typo in blink status Raghava Aditya Renukunta
2017-03-03 18:34 ` Dave Carroll
2017-03-07 3:24 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox