[bug report] scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.

[bug report] scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.

[Dan Carpenter]

Hello Dupuis, Chad,

This is a semi-automatic email about new static checker warnings.

The patch 61d8658b4a43: "scsi: qedf: Add QLogic FastLinQ offload FCoE 
driver framework." from Feb 15, 2017, leads to the following Smatch 
complaint:

drivers/scsi/qedf/qedf_main.c:1565 qedf_vport_destroy()
	 warn: variable dereferenced before check 'vn_port->host' (see line 1551)

drivers/scsi/qedf/qedf_main.c
  1550		/* Detach from scsi-ml */
  1551		fc_remove_host(vn_port->host);
                               ^^^^^^^^^^^^^
Dereferenced inside function.

  1552		scsi_remove_host(vn_port->host);
  1553	
  1554		/*
  1555		 * Only try to release the exchange manager if the vn_port
  1556		 * configuration is complete.
  1557		 */
  1558		if (vn_port->state == LPORT_ST_READY)
  1559			fc_exch_mgr_free(vn_port);
  1560	
  1561		/* Free memory used by statistical counters */
  1562		fc_lport_free_stats(vn_port);
  1563	
  1564		/* Release Scsi_Host */
  1565		if (vn_port->host)
                    ^^^^^^^^^^^^^
Too late.

  1566			scsi_host_put(vn_port->host);
  1567	

regards,
dan carpenter

[bug report] scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.

[Dan Carpenter]

Hello Dupuis, Chad,

The patch 61d8658b4a43: "scsi: qedf: Add QLogic FastLinQ offload FCoE
driver framework." from Feb 15, 2017, leads to the following static
checker warning:

	drivers/scsi/qedf/qedf_main.c:1168 qedf_rport_event_handler()
	warn: 'rval' can be either negative or positive

drivers/scsi/qedf/qedf_main.c
  1005  static int qedf_offload_connection(struct qedf_ctx *qedf,
  1006          struct qedf_rport *fcport)
  1007  {
  1008          struct qed_fcoe_params_offload conn_info;
  1009          u32 port_id;
  1010          u8 lport_src_id[3];
  1011          int rval;
  1012          uint16_t total_sqe = (fcport->sq_mem_size / sizeof(struct fcoe_wqe));
  1013  
  1014          QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "Offloading connection "
  1015                     "portid=%06x.\n", fcport->rdata->ids.port_id);
  1016          rval = qed_ops->acquire_conn(qedf->cdev, &fcport->handle,
  1017              &fcport->fw_cid, &fcport->p_doorbell);
  1018          if (rval) {
  1019                  QEDF_WARN(&(qedf->dbg_ctx), "Could not acquire connection "
  1020                             "for portid=%06x.\n", fcport->rdata->ids.port_id);
  1021                  rval = 1; /* For some reason qed returns 0 on failure here */

What kind of an error is 1 supposed to indicate?  This needs to be
not a magic number and commented.

  1022                  goto out;
  1023          }
  1024  
  1025          QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_CONN, "portid=%06x "
  1026                     "fw_cid=%08x handle=%d.\n", fcport->rdata->ids.port_id,
  1027                     fcport->fw_cid, fcport->handle);
  1028  
  1029          memset(&conn_info, 0, sizeof(struct qed_fcoe_params_offload));
  1030  

regards,
dan carpenter