From: Christoph Hellwig <hch@infradead.org>
To: jsmart2021@gmail.com
Cc: linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH] lpfc: Finalize Kconfig options for nvme
Date: Tue, 7 Mar 2017 13:23:51 -0800 [thread overview]
Message-ID: <20170307212351.GA5697@infradead.org> (raw)
In-Reply-To: <1488914228-7289-1-git-send-email-jsmart2021@gmail.com>
> +#if defined(CONFIG_NVME_FC)
> +#define CONFIG_LPFC_NVME_INITIATOR
> +#endif
> +
> +#if defined(CONFIG_NVME_TARGET_FC)
> +#define CONFIG_LPFC_NVME_TARGET
> +#endif
The CONFIG_* namespace is reserved for Kconfig defined symbols.
Also I think the above is wrong if the nvme fc core code is built
modular. I think you want to replace all occurances of
#ifdef CONFIG_LPFC_NVME_INITIATOR
with
if (IS_ENABLED(CONFIG_NVME_FC))
and vice versa for the taget.
next prev parent reply other threads:[~2017-03-07 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 19:17 [PATCH] lpfc: Finalize Kconfig options for nvme jsmart2021
2017-03-07 21:23 ` Christoph Hellwig [this message]
2017-03-07 21:37 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307212351.GA5697@infradead.org \
--to=hch@infradead.org \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox