Re: [PATCH] csiostor: switch to pci_alloc_irq_vectors

[Varun Prakash <varun@chelsio.com>]

On Fri, Mar 31, 2017 at 12:25:27PM +0530, Christoph Hellwig wrote:
> On Fri, Jan 20, 2017 at 07:27:02PM -0500, Martin K. Petersen wrote:
> > >>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:
> >
> > Christoph> And get automatic MSI-X affinity for free.
> >
> > Chelsio folks: Please review and test!
>
> ping!

csiostor driver is triggering WARN_ON with this patch
drivers/pci/msi.c:1193

1172 int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
1173                                    unsigned int max_vecs, unsigned int flags,
1174                                    const struct irq_affinity *affd)
1175 {
1176         static const struct irq_affinity msi_default_affd;
1177         int vecs = -ENOSPC;
1178
1179         if (flags & PCI_IRQ_AFFINITY) {
		...
1192         } else {
1193                 if (WARN_ON(affd))
1194                         affd = NULL;
1195         }


PCI_IRQ_AFFINITY flag is missing

+	cnt = pci_alloc_irq_vectors_affinity(hw->pdev, min, cnt, PCI_IRQ_MSIX,
+			&desc);
+	if (cnt < 0)
 		return cnt;
-	}