From mboxrd@z Thu Jan 1 00:00:00 1970 From: "hch@lst.de" Subject: Re: [PATCH 02/23] block: remove the blk_execute_rq return value Date: Thu, 20 Apr 2017 07:11:12 +0200 Message-ID: <20170420051112.GA10822@lst.de> References: <20170419192708.22098-1-hch@lst.de> <20170419192708.22098-3-hch@lst.de> <1492636063.2543.18.camel@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:38763 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938141AbdDTFLO (ORCPT ); Thu, 20 Apr 2017 01:11:14 -0400 Content-Disposition: inline In-Reply-To: <1492636063.2543.18.camel@sandisk.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: "hch@lst.de" , "axboe@kernel.dk" , "linux-block@vger.kernel.org" , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "jbacik@fb.com" , "james.smart@broadcom.com" , "dm-devel@redhat.com" On Wed, Apr 19, 2017 at 09:07:45PM +0000, Bart Van Assche wrote: > > + blk_execute_rq(or->request->q, NULL, or->request, 0); > > + error = or->request ? -EIO : 0; > > Hello Christoph, > > Did you perhaps intend or->request->errors instead of or->request? Yes, thanks.