Re: [PATCH-v1 19/22] Fix implicit logo and RSCN handling for NVMET

Johannes Thumshirn
2017-04-20T07:54:02Z

On Wed, Apr 19, 2017 at 09:46:38PM -0700, jsmart2021@gmail.com wrote:
> From: James Smart <jsmart2021@gmail.com>
>
> NVMET didn't have any RSCN handling at all and
> would not execute implicit LOGO when receiving a PLOGI
> from an rport that NVMET had in state UNMAPPED.
>
> Clean up the logic in lpfc_nlp_state_cleanup for
> initiators (FCP and NVME). NVMET should not respond to
> RSCN including allocating new ndlps so this code was
> conditionalized when nvmet_support is true. The check
> for NLP_RCV_PLOGI in lpfc_setup_disc_node was moved
> below the check for nvmet_support to allow the NVMET
> to recover initiator nodes correctly. The implicit
> logo was introduced with lpfc_rcv_plogi when NVMET gets
> a PLOGI on an ndlp in UNMAPPED state. The RSCN handling
> was modified to not respond to an RSCN in NVMET. Instead
> NVMET sends a GID_FT and determines if an NVMEP_INITIATOR
> it has is UNMAPPED but no longer in the zone membership.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850