Re: [PATCH-v1 11/22] Fix driver unload/reload operation.

Junichi Nomura
2017-04-20T09:11:27Z

On 04/20/17 16:37, Johannes Thumshirn wrote:
> On Wed, Apr 19, 2017 at 09:46:30PM -0700, jsmart2021@gmail.com wrote:
>> From: James Smart <jsmart2021@gmail.com>
>>
>> There are couple of different load/unload issues fixed with this patch.
>> One of the issues was reported by Junichi Nomura, a patch was submitted
>> by Johannes Thumsrhirn which did fix one of the problems but the fix in
>> this patch separates the pring free from the queue free and does not set
>> the parameter passed in to NULL.
>>
>> issues:
>> (1) driver could not be unloaded and reloaded without some Oops or
>> Panic occurring.
>> (2) The driver was panicking because of a corruption in the Memory
>> Manager when the iocb list was getting allocated.
>>
>> Root cause for the memory corruption was a double free of the Work Queue
>> ring pointer memory - Freed once in the lpfc_sli4_queue_free when the CQ
>> was destroyed and again in lpfc_sli4_queue_free when the WQ was destroyed.
>>
>> The pring free and the queue free were separated, the pring free was moved
>> to the wq destroy routine because it a better fit logically to delete the
>> ring with the wq.
>>
>> The checkpatch flagged several alignmenet issues that were also corrected
>> with this patch.
>>
>> The mboxq was never initialed correctly before it was used by the driver
>> this patch corrects that issue.
>>
>> Reported-by: Junichi Nomura <j-nomura@ce.jp.nec.com>
>> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
>> Signed-off-by: James Smart <james.smart@broadcom.com>
>> ---
>
> Looks good,
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> But I'd really like to see a Tested-by from Junichi here.

Thank you for Cc-ing to me.

I tested the patch on top of v4.11-rc7 and confirmed the reported
problem doesn't occur. So,
Tested-by: Junichi Nomura <j-nomura@ce.jp.nec.com>

--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.