From: kusumi.tomohiro@gmail.com
To: subhashj@codeaurora.org, vinholikatti@gmail.com,
linux-scsi@vger.kernel.org
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: [PATCH 1/2] scsi: ufs: use MASK_EE_STATUS
Date: Thu, 20 Apr 2017 15:01:44 +0300 [thread overview]
Message-ID: <20170420120145.7035-1-tkusumi@tuxera.com> (raw)
From: Tomohiro Kusumi <tkusumi@tuxera.com>
MASK_EE_STATUS added by 66ec6d59 was unused, but it seems to have been
defined to do this.
Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 096e95b..9278666 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4717,7 +4717,7 @@ static int ufshcd_disable_ee(struct ufs_hba *hba, u16 mask)
goto out;
val = hba->ee_ctrl_mask & ~mask;
- val &= 0xFFFF; /* 2 bytes */
+ val &= MASK_EE_STATUS;
err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
QUERY_ATTR_IDN_EE_CONTROL, 0, 0, &val);
if (!err)
@@ -4745,7 +4745,7 @@ static int ufshcd_enable_ee(struct ufs_hba *hba, u16 mask)
goto out;
val = hba->ee_ctrl_mask | mask;
- val &= 0xFFFF; /* 2 bytes */
+ val &= MASK_EE_STATUS;
err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
QUERY_ATTR_IDN_EE_CONTROL, 0, 0, &val);
if (!err)
--
2.9.3
next reply other threads:[~2017-04-20 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 12:01 kusumi.tomohiro [this message]
2017-04-20 12:01 ` [PATCH 2/2] scsi: ufs: make ufshcd_get_lists_status() register operation obvious kusumi.tomohiro
2017-04-26 16:49 ` Subhash Jadavani
2017-04-26 17:04 ` Tomohiro Kusumi
2017-04-24 22:34 ` [PATCH 1/2] scsi: ufs: use MASK_EE_STATUS Martin K. Petersen
2017-04-26 16:39 ` Subhash Jadavani
2017-04-26 22:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420120145.7035-1-tkusumi@tuxera.com \
--to=kusumi.tomohiro@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=subhashj@codeaurora.org \
--cc=tkusumi@tuxera.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox