From: jsmart2021@gmail.com
To: linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
sagi@grimberg.me, martin.petersen@oracle.com
Cc: James Smart <jsmart2021@gmail.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: [PATCH v3 10/22] Fix PRLI ACC rsp for NVME
Date: Fri, 21 Apr 2017 16:04:54 -0700 [thread overview]
Message-ID: <20170421230506.925-11-jsmart2021@gmail.com> (raw)
In-Reply-To: <20170421230506.925-1-jsmart2021@gmail.com>
From: James Smart <jsmart2021@gmail.com>
PRLI ACC from target is FCP oriented.
Word 0 was wrong. This was noticed by another nvmet-fc vendor that
was testing the lpfc nvme-fc initiator with their target.
Verified results with analyzer.
PRLI
BC B5 56 56 22 61 04 00 00 61 00 00 01 29 00 00 20 00 00 00
00 10 FF FF 00 00 00 00 20 14 00 18 28 00 00 00 00 00 00 00
00 00 00 00 00 00 00 20 00 00 00 00 9C D8 DA C9 BC 95 75 75
ACC
BC B5 56 56 23 61 00 00 00 61 04 00 01 98 00 00 30 00 00 00
00 10 00 18 00 00 00 00 02 14 00 18 28 00 01 00 00 00 00 00
00 00 00 00 00 00 00 18 00 00 00 00 B0 6B 07 57 BC B5 75 75
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/scsi/lpfc/lpfc_els.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index d9c61d0..d6e0f58 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4403,7 +4403,7 @@ lpfc_els_rsp_prli_acc(struct lpfc_vport *vport, struct lpfc_iocbq *oldiocb,
pcmd = (uint8_t *) (((struct lpfc_dmabuf *) elsiocb->context2)->virt);
memset(pcmd, 0, cmdsize);
- *((uint32_t *) (pcmd)) = (ELS_CMD_ACC | (ELS_CMD_PRLI & ~ELS_RSP_MASK));
+ *((uint32_t *)(pcmd)) = elsrspcmd;
pcmd += sizeof(uint32_t);
/* For PRLI, remainder of payload is PRLI parameter page */
--
2.9.3
next prev parent reply other threads:[~2017-04-21 23:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 23:04 [PATCH v3 00/22] lpfc updates for 11.2.0.12 jsmart2021
2017-04-21 23:04 ` [PATCH v3 01/22] Standardize nvme SGL segment count jsmart2021
2017-04-21 23:04 ` [PATCH v3 02/22] Fix nvme unregister port timeout jsmart2021
2017-04-21 23:04 ` [PATCH v3 03/22] Fix rejected nvme LS Req jsmart2021
2017-04-21 23:04 ` [PATCH v3 04/22] Fix log message in completion path jsmart2021
2017-04-21 23:04 ` [PATCH v3 05/22] Add debug messages for nvme/fcp resource allocation jsmart2021
2017-04-21 23:04 ` [PATCH v3 06/22] Fix spelling in comments jsmart2021
2017-04-21 23:04 ` [PATCH v3 07/22] Remove unused defines for NVME PostBuf jsmart2021
2017-04-21 23:04 ` [PATCH v3 08/22] Remove NULL ptr check before kfree jsmart2021
2017-04-21 23:04 ` [PATCH v3 09/22] Fix extra line print in rqpair debug print jsmart2021
2017-04-21 23:04 ` jsmart2021 [this message]
2017-04-21 23:04 ` [PATCH v3 11/22] Fix driver unload/reload operation jsmart2021
2017-04-21 23:04 ` [PATCH v3 12/22] Fix driver usage of 128B WQEs when WQ_CREATE is V1 jsmart2021
2017-04-21 23:04 ` [PATCH v3 13/22] Fix nvme initiator handling when not enabled jsmart2021
2017-04-21 23:04 ` [PATCH v3 14/22] Remove hba lock from NVMET issue WQE jsmart2021
2017-04-21 23:04 ` [PATCH v3 15/22] Fix driver load issues when MRQ=8 jsmart2021
2017-04-21 23:05 ` [PATCH v3 16/22] Fix crash after issuing lip reset jsmart2021
2017-04-21 23:05 ` [PATCH v3 17/22] Fix max_sgl_segments settings for NVME / NVMET jsmart2021
2017-04-21 23:05 ` [PATCH v3 18/22] Add Fabric assigned WWN support jsmart2021
2017-04-21 23:05 ` [PATCH v3 19/22] Fix implicit logo and RSCN handling for NVMET jsmart2021
2017-04-21 23:05 ` [PATCH v3 20/22] Update ABORT processing " jsmart2021
2017-04-21 23:05 ` [PATCH v3 21/22] Fix Express lane queue creation jsmart2021
2017-04-21 23:05 ` [PATCH v3 22/22] lpfc revison 11.2.0.12 jsmart2021
2017-04-24 7:26 ` [PATCH v3 00/22] lpfc updates for 11.2.0.12 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421230506.925-11-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox