public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: jsmart2021@gmail.com
To: linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
	sagi@grimberg.me, martin.petersen@oracle.com
Cc: James Smart <jsmart2021@gmail.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	James Smart <james.smart@broadcom.com>
Subject: [PATCH v3 21/22] Fix Express lane queue creation.
Date: Fri, 21 Apr 2017 16:05:05 -0700	[thread overview]
Message-ID: <20170421230506.925-22-jsmart2021@gmail.com> (raw)
In-Reply-To: <20170421230506.925-1-jsmart2021@gmail.com>

From: James Smart <jsmart2021@gmail.com>

The older sli4 adapters only supported the 64 byte WQE entry size.
The new adapter (fw) support both 64 and 128 byte WQE entry sizies.
The Express lane WQ was not being created with the 128 byte WQE sizes
when it was supported.

Not having the right WQE size created for the express lane work queue
caused the the firmware to overwrite the lun indentifier in the FCP header.

This patch correctly creates the express lane work queue with the
supported size.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 drivers/scsi/lpfc/lpfc_init.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 74cec22..90ae354 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -12040,6 +12040,7 @@ int
 lpfc_fof_queue_create(struct lpfc_hba *phba)
 {
 	struct lpfc_queue *qdesc;
+	uint32_t wqesize;
 
 	/* Create FOF EQ */
 	qdesc = lpfc_sli4_queue_alloc(phba, phba->sli4_hba.eq_esize,
@@ -12060,8 +12061,11 @@ lpfc_fof_queue_create(struct lpfc_hba *phba)
 		phba->sli4_hba.oas_cq = qdesc;
 
 		/* Create OAS WQ */
-		qdesc = lpfc_sli4_queue_alloc(phba, phba->sli4_hba.wq_esize,
+		wqesize = (phba->fcp_embed_io) ?
+				LPFC_WQE128_SIZE : phba->sli4_hba.wq_esize;
+		qdesc = lpfc_sli4_queue_alloc(phba, wqesize,
 					      phba->sli4_hba.wq_ecount);
+
 		if (!qdesc)
 			goto out_error;
 
-- 
2.9.3

  parent reply	other threads:[~2017-04-21 23:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 23:04 [PATCH v3 00/22] lpfc updates for 11.2.0.12 jsmart2021
2017-04-21 23:04 ` [PATCH v3 01/22] Standardize nvme SGL segment count jsmart2021
2017-04-21 23:04 ` [PATCH v3 02/22] Fix nvme unregister port timeout jsmart2021
2017-04-21 23:04 ` [PATCH v3 03/22] Fix rejected nvme LS Req jsmart2021
2017-04-21 23:04 ` [PATCH v3 04/22] Fix log message in completion path jsmart2021
2017-04-21 23:04 ` [PATCH v3 05/22] Add debug messages for nvme/fcp resource allocation jsmart2021
2017-04-21 23:04 ` [PATCH v3 06/22] Fix spelling in comments jsmart2021
2017-04-21 23:04 ` [PATCH v3 07/22] Remove unused defines for NVME PostBuf jsmart2021
2017-04-21 23:04 ` [PATCH v3 08/22] Remove NULL ptr check before kfree jsmart2021
2017-04-21 23:04 ` [PATCH v3 09/22] Fix extra line print in rqpair debug print jsmart2021
2017-04-21 23:04 ` [PATCH v3 10/22] Fix PRLI ACC rsp for NVME jsmart2021
2017-04-21 23:04 ` [PATCH v3 11/22] Fix driver unload/reload operation jsmart2021
2017-04-21 23:04 ` [PATCH v3 12/22] Fix driver usage of 128B WQEs when WQ_CREATE is V1 jsmart2021
2017-04-21 23:04 ` [PATCH v3 13/22] Fix nvme initiator handling when not enabled jsmart2021
2017-04-21 23:04 ` [PATCH v3 14/22] Remove hba lock from NVMET issue WQE jsmart2021
2017-04-21 23:04 ` [PATCH v3 15/22] Fix driver load issues when MRQ=8 jsmart2021
2017-04-21 23:05 ` [PATCH v3 16/22] Fix crash after issuing lip reset jsmart2021
2017-04-21 23:05 ` [PATCH v3 17/22] Fix max_sgl_segments settings for NVME / NVMET jsmart2021
2017-04-21 23:05 ` [PATCH v3 18/22] Add Fabric assigned WWN support jsmart2021
2017-04-21 23:05 ` [PATCH v3 19/22] Fix implicit logo and RSCN handling for NVMET jsmart2021
2017-04-21 23:05 ` [PATCH v3 20/22] Update ABORT processing " jsmart2021
2017-04-21 23:05 ` jsmart2021 [this message]
2017-04-21 23:05 ` [PATCH v3 22/22] lpfc revison 11.2.0.12 jsmart2021
2017-04-24  7:26 ` [PATCH v3 00/22] lpfc updates for 11.2.0.12 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170421230506.925-22-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox