From: Wei Yongjun <weiyj.lk@gmail.com>
To: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-scsi@vger.kernel.org
Subject: [PATCH -next] [SCSI] mac_esp: fix to pass correct device identity to free_irq()
Date: Tue, 25 Apr 2017 03:08:45 +0000 [thread overview]
Message-ID: <20170425030845.7809-1-weiyj.lk@gmail.com> (raw)
From: Wei Yongjun <weiyongjun1@huawei.com>
free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/scsi/mac_esp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c
index bb567d3..dda4da2 100644
--- a/drivers/scsi/mac_esp.c
+++ b/drivers/scsi/mac_esp.c
@@ -580,7 +580,7 @@ static int esp_mac_probe(struct platform_device *dev)
fail_free_irq:
if (esp_chips[!dev->id] == NULL)
- free_irq(host->irq, esp);
+ free_irq(host->irq, NULL);
fail_free_priv:
kfree(mep);
fail_free_command_block:
next reply other threads:[~2017-04-25 3:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 3:08 Wei Yongjun [this message]
2017-04-26 5:43 ` [PATCH] mac_esp: fix to pass correct device identity to free_irq() Finn Thain
2017-04-26 22:31 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425030845.7809-1-weiyj.lk@gmail.com \
--to=weiyj.lk@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox