Re: [PATCH] libfc: do not flood console with messages 'libfc: queue full ...'

Bart Van Assche
2017-04-27T16:07:34Z

On Thu, 2017-04-27 at 16:25 +0200, Hannes Reinecke wrote:
> @@ -1896,11 +1899,11 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd)
>
> if (!fc_fcp_lport_queue_ready(lport)) {
> if (lport->qfull) {
> - fc_fcp_can_queue_ramp_down(lport);
> - shost_printk(KERN_ERR, lport->host,
> - "libfc: queue full, "
> - "reducing can_queue to %d.\n",
> - lport->host->can_queue);
> + if (fc_fcp_can_queue_ramp_down(lport))
> + shost_printk(KERN_ERR, lport->host,
> + "libfc: queue full, "
> + "reducing can_queue to %d.\n",
> + lport->host->can_queue);
> }
> rc = SCSI_MLQUEUE_HOST_BUSY;
> goto out;

Hello Hannes,

Although this would have been a good opportunity to join the log message
that has been split over two lines:

Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>