From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Omar Sandoval <osandov@osandov.com>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH blktests 0/3] Add SCSI generic test group
Date: Sun, 21 May 2017 00:03:22 -0700 [thread overview]
Message-ID: <20170521070322.GA10453@infradead.org> (raw)
In-Reply-To: <94150f71-5bbb-2ee2-b7d4-d0f2f7124684@suse.de>
On Thu, May 18, 2017 at 03:29:45PM +0200, Johannes Thumshirn wrote:
> On 05/18/2017 03:19 PM, Christoph Hellwig wrote:
> > All SG_IO test should also apply to block device nodes that support
> > the ioctl..
> >
>
> But these are not necessarily SG_IO tests, are they?
>
> The test included is doesn't hit the SG_IO path in the sg driver, but
> the sg_read path.
Oh, you're right.
>
> Of cause we can make a generic sg_io tool but IMHO it's quite convenient
> to just throw in the reproducers we get.
>
> And as it exercises the /dev/sg character device I decided to make a new
> group.
Yeah, makes sense. And any SG_IO test should be able to run on
both block device nodes and sg nodes.
prev parent reply other threads:[~2017-05-21 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 12:13 [PATCH blktests 0/3] Add SCSI generic test group Johannes Thumshirn
2017-05-18 12:13 ` [PATCH blktests 1/3] Add ability to build test-cases Johannes Thumshirn
2017-05-18 12:13 ` [PATCH blktests 2/3] tests/sg: add SCSI generic test grouop Johannes Thumshirn
2017-05-18 21:06 ` Omar Sandoval
2017-05-18 21:38 ` Omar Sandoval
2017-05-18 12:13 ` [PATCH blktests 3/3] sg/001: add regression test for syzcaller generated GPF Johannes Thumshirn
2017-05-18 21:28 ` Omar Sandoval
2017-05-18 13:19 ` [PATCH blktests 0/3] Add SCSI generic test group Christoph Hellwig
2017-05-18 13:29 ` Johannes Thumshirn
2017-05-18 22:46 ` Omar Sandoval
2017-05-19 6:41 ` Johannes Thumshirn
2017-05-21 7:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521070322.GA10453@infradead.org \
--to=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox