From: Bart Van Assche <bart.vanassche@sandisk.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.com>
Subject: [PATCH 17/31] block: Introduce request_queue.initialize_rq_fn()
Date: Tue, 23 May 2017 17:34:06 -0700 [thread overview]
Message-ID: <20170524003420.5381-18-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170524003420.5381-1-bart.vanassche@sandisk.com>
Several block drivers need to initialize the driver-private data
after having called blk_get_request() and before .prep_rq_fn() is
called, e.g. when submitting a REQ_OP_SCSI_* request. Avoid that
that initialization code has to be repeated after every
blk_get_request() call by adding a new callback function to struct
request_queue.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: linux-block@vger.kernel.org
---
block/blk-core.c | 3 +++
block/blk-mq.c | 3 +++
include/linux/blkdev.h | 4 ++++
3 files changed, 10 insertions(+)
diff --git a/block/blk-core.c b/block/blk-core.c
index 55a7b76db7c2..8a680f7bb168 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -126,6 +126,9 @@ void blk_rq_init(struct request_queue *q, struct request *rq)
rq->start_time = jiffies;
set_start_time_ns(rq);
rq->part = NULL;
+
+ if (q->initialize_rq_fn)
+ q->initialize_rq_fn(rq);
}
EXPORT_SYMBOL(blk_rq_init);
diff --git a/block/blk-mq.c b/block/blk-mq.c
index a69ad122ed66..2af43d4e5b96 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -241,6 +241,9 @@ void blk_mq_rq_ctx_init(struct request_queue *q, struct blk_mq_ctx *ctx,
rq->end_io_data = NULL;
rq->next_rq = NULL;
+ if (q->initialize_rq_fn)
+ q->initialize_rq_fn(rq);
+
ctx->rq_dispatched[op_is_sync(op)]++;
}
EXPORT_SYMBOL_GPL(blk_mq_rq_ctx_init);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 6416a5834b05..e3c03d429371 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -410,8 +410,12 @@ struct request_queue {
rq_timed_out_fn *rq_timed_out_fn;
dma_drain_needed_fn *dma_drain_needed;
lld_busy_fn *lld_busy_fn;
+ /* Called just after a request is allocated */
init_rq_fn *init_rq_fn;
+ /* Called just before a request is freed */
exit_rq_fn *exit_rq_fn;
+ /* Called from inside blk_get_request() */
+ void (*initialize_rq_fn)(struct request *rq);
const struct blk_mq_ops *mq_ops;
--
2.12.2
next prev parent reply other threads:[~2017-05-24 0:34 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 0:33 [PATCH 00/31] SCSI patches for kernel v4.13 Bart Van Assche
2017-05-24 0:33 ` [PATCH 01/31] Split scsi_internal_device_block() Bart Van Assche
2017-05-24 5:48 ` Hannes Reinecke
2017-05-24 7:36 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 02/31] Create two versions of scsi_internal_device_unblock() Bart Van Assche
2017-05-24 5:48 ` Hannes Reinecke
2017-05-24 7:38 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 03/31] Protect SCSI device state changes with a mutex Bart Van Assche
2017-05-24 5:51 ` Hannes Reinecke
2017-05-24 15:10 ` Bart Van Assche
2017-05-24 0:33 ` [PATCH 04/31] Introduce scsi_start_queue() Bart Van Assche
2017-05-24 5:51 ` Hannes Reinecke
2017-05-24 0:33 ` [PATCH 05/31] Make __scsi_remove_device go straight from BLOCKED to DEL Bart Van Assche
2017-05-24 5:52 ` Hannes Reinecke
2017-05-24 0:33 ` [PATCH 06/31] scmd_eh_abort_handler(): Add a comment Bart Van Assche
2017-05-24 5:53 ` Hannes Reinecke
2017-05-24 0:33 ` [PATCH 07/31] scsi: Use blk_mq_rq_to_pdu() to convert a request to a SCSI command pointer Bart Van Assche
2017-05-24 5:54 ` Hannes Reinecke
2017-05-24 7:50 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 08/31] sd, sr: Convert two assignments into warning statements Bart Van Assche
2017-05-24 5:55 ` Hannes Reinecke
2017-05-24 7:52 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 09/31] block: Avoid that blk_exit_rl() triggers a use-after-free Bart Van Assche
2017-05-24 5:55 ` Hannes Reinecke
2017-05-24 15:09 ` Tejun Heo
2017-05-24 0:33 ` [PATCH 10/31] Avoid that scsi_exit_rq() " Bart Van Assche
2017-05-24 5:58 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 11/31] block: Introduce queue flag QUEUE_FLAG_SCSI_SUP Bart Van Assche
2017-05-24 6:01 ` Hannes Reinecke
2017-05-24 15:05 ` Bart Van Assche
2017-05-24 0:34 ` [PATCH 12/31] bsg: Check queue type before attaching to a queue Bart Van Assche
2017-05-24 6:01 ` Hannes Reinecke
2017-05-25 2:01 ` Martin K. Petersen
2017-05-24 0:34 ` [PATCH 13/31] pktcdvd: " Bart Van Assche
2017-05-24 6:02 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 14/31] cdrom: Check private request size " Bart Van Assche
2017-05-24 6:02 ` Hannes Reinecke
[not found] ` <20170524003420.5381-1-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-24 0:34 ` [PATCH 15/31] nfsd: Check private request size before submitting a SCSI request Bart Van Assche
[not found] ` <20170524003420.5381-16-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-24 6:02 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 16/31] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init() Bart Van Assche
2017-05-24 6:03 ` Hannes Reinecke
2017-05-24 0:34 ` Bart Van Assche [this message]
2017-05-24 6:04 ` [PATCH 17/31] block: Introduce request_queue.initialize_rq_fn() Hannes Reinecke
2017-05-24 0:34 ` [PATCH 18/31] block: Make scsi_req_init() calls implicit Bart Van Assche
2017-05-24 6:05 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 19/31] scsi: Change argument type of scsi_req_init() Bart Van Assche
2017-05-24 6:06 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 20/31] scsi: Only add commands to the device command list if required by the LLD Bart Van Assche
2017-05-24 6:07 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 21/31] scsi: Move most of scsi_init_command() into scsi_initialize_rq() Bart Van Assche
2017-05-24 6:09 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 22/31] scsi: Inline scsi_init_command() Bart Van Assche
2017-05-24 6:09 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 23/31] scsi: Move sense buffer pointer initialization into scsi_initialize_rq() Bart Van Assche
2017-05-24 6:10 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 24/31] scsi: Make scsi_initialize_rq() zero the entire struct scsi_cmnd Bart Van Assche
2017-05-24 6:10 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 25/31] scsi-mq: Make behavior scsi_mq_prep_fn() closer to that of scsi_prep_fn() Bart Van Assche
2017-05-24 6:11 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 26/31] scsi: Move the code for clearing private command data into scsi_dispatch_cmd() Bart Van Assche
2017-05-24 6:12 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 27/31] scsi: Consolidate more initialization code Bart Van Assche
2017-05-24 6:13 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 28/31] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it Bart Van Assche
2017-05-24 6:13 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 29/31] scsi: snic: Remove code that zeroes driver-private command data Bart Van Assche
2017-05-24 6:14 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 30/31] scsi: virtio: " Bart Van Assche
2017-05-24 6:14 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 31/31] xen/scsifront: " Bart Van Assche
2017-05-24 6:14 ` Hannes Reinecke
2017-05-24 7:02 ` Juergen Gross
2017-05-24 2:31 ` [PATCH 00/31] SCSI patches for kernel v4.13 Martin K. Petersen
2017-05-24 3:55 ` Jens Axboe
2017-05-24 4:43 ` Bart Van Assche
2017-05-25 2:04 ` Martin K. Petersen
2017-06-01 14:08 ` Bart Van Assche
2017-06-01 14:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524003420.5381-18-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox