From: Tejun Heo <tj@kernel.org>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Jan Kara <jack@suse.cz>, Hannes Reinecke <hare@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 09/31] block: Avoid that blk_exit_rl() triggers a use-after-free
Date: Wed, 24 May 2017 11:09:32 -0400 [thread overview]
Message-ID: <20170524150932.GC24798@htj.duckdns.org> (raw)
In-Reply-To: <20170524003420.5381-10-bart.vanassche@sandisk.com>
On Tue, May 23, 2017 at 05:33:58PM -0700, Bart Van Assche wrote:
> Since the introduction of the .init_rq_fn() and .exit_rq_fn() it
> is essential that the memory allocated for struct request_queue
> stays around until all blk_exit_rl() calls have finished. Hence
> make blk_init_rl() take a reference on struct request_queue.
>
> This patch fixes the following crash:
>
> general protection fault: 0000 [#2] SMP
> CPU: 3 PID: 28 Comm: ksoftirqd/3 Tainted: G D 4.12.0-rc2-dbg+ #2
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014
> task: ffff88013a108040 task.stack: ffffc9000071c000
> RIP: 0010:free_request_size+0x1a/0x30
> RSP: 0018:ffffc9000071fd38 EFLAGS: 00010202
> RAX: 6b6b6b6b6b6b6b6b RBX: ffff880067362a88 RCX: 0000000000000003
> RDX: ffff880067464178 RSI: ffff880067362a88 RDI: ffff880135ea4418
> RBP: ffffc9000071fd40 R08: 0000000000000000 R09: 0000000100180009
> R10: ffffc9000071fd38 R11: ffffffff81110800 R12: ffff88006752d3d8
> R13: ffff88006752d3d8 R14: ffff88013a108040 R15: 000000000000000a
> FS: 0000000000000000(0000) GS:ffff88013fd80000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007fa8ec1edb00 CR3: 0000000138ee8000 CR4: 00000000001406e0
> Call Trace:
> mempool_destroy.part.10+0x21/0x40
> mempool_destroy+0xe/0x10
> blk_exit_rl+0x12/0x20
> blkg_free+0x4d/0xa0
> __blkg_release_rcu+0x59/0x170
> rcu_process_callbacks+0x260/0x4e0
> __do_softirq+0x116/0x250
> smpboot_thread_fn+0x123/0x1e0
> kthread+0x109/0x140
> ret_from_fork+0x31/0x40
>
> Fixes: commit e9c787e65c0c ("scsi: allocate scsi_cmnd structures as part of struct request")
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: <stable@vger.kernel.org> # v4.11+
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-24 15:09 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 0:33 [PATCH 00/31] SCSI patches for kernel v4.13 Bart Van Assche
2017-05-24 0:33 ` [PATCH 01/31] Split scsi_internal_device_block() Bart Van Assche
2017-05-24 5:48 ` Hannes Reinecke
2017-05-24 7:36 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 02/31] Create two versions of scsi_internal_device_unblock() Bart Van Assche
2017-05-24 5:48 ` Hannes Reinecke
2017-05-24 7:38 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 03/31] Protect SCSI device state changes with a mutex Bart Van Assche
2017-05-24 5:51 ` Hannes Reinecke
2017-05-24 15:10 ` Bart Van Assche
2017-05-24 0:33 ` [PATCH 04/31] Introduce scsi_start_queue() Bart Van Assche
2017-05-24 5:51 ` Hannes Reinecke
2017-05-24 0:33 ` [PATCH 05/31] Make __scsi_remove_device go straight from BLOCKED to DEL Bart Van Assche
2017-05-24 5:52 ` Hannes Reinecke
2017-05-24 0:33 ` [PATCH 06/31] scmd_eh_abort_handler(): Add a comment Bart Van Assche
2017-05-24 5:53 ` Hannes Reinecke
2017-05-24 0:33 ` [PATCH 07/31] scsi: Use blk_mq_rq_to_pdu() to convert a request to a SCSI command pointer Bart Van Assche
2017-05-24 5:54 ` Hannes Reinecke
2017-05-24 7:50 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 08/31] sd, sr: Convert two assignments into warning statements Bart Van Assche
2017-05-24 5:55 ` Hannes Reinecke
2017-05-24 7:52 ` Johannes Thumshirn
2017-05-24 0:33 ` [PATCH 09/31] block: Avoid that blk_exit_rl() triggers a use-after-free Bart Van Assche
2017-05-24 5:55 ` Hannes Reinecke
2017-05-24 15:09 ` Tejun Heo [this message]
2017-05-24 0:33 ` [PATCH 10/31] Avoid that scsi_exit_rq() " Bart Van Assche
2017-05-24 5:58 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 11/31] block: Introduce queue flag QUEUE_FLAG_SCSI_SUP Bart Van Assche
2017-05-24 6:01 ` Hannes Reinecke
2017-05-24 15:05 ` Bart Van Assche
2017-05-24 0:34 ` [PATCH 12/31] bsg: Check queue type before attaching to a queue Bart Van Assche
2017-05-24 6:01 ` Hannes Reinecke
2017-05-25 2:01 ` Martin K. Petersen
2017-05-24 0:34 ` [PATCH 13/31] pktcdvd: " Bart Van Assche
2017-05-24 6:02 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 14/31] cdrom: Check private request size " Bart Van Assche
2017-05-24 6:02 ` Hannes Reinecke
[not found] ` <20170524003420.5381-1-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-24 0:34 ` [PATCH 15/31] nfsd: Check private request size before submitting a SCSI request Bart Van Assche
[not found] ` <20170524003420.5381-16-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-24 6:02 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 16/31] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init() Bart Van Assche
2017-05-24 6:03 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 17/31] block: Introduce request_queue.initialize_rq_fn() Bart Van Assche
2017-05-24 6:04 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 18/31] block: Make scsi_req_init() calls implicit Bart Van Assche
2017-05-24 6:05 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 19/31] scsi: Change argument type of scsi_req_init() Bart Van Assche
2017-05-24 6:06 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 20/31] scsi: Only add commands to the device command list if required by the LLD Bart Van Assche
2017-05-24 6:07 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 21/31] scsi: Move most of scsi_init_command() into scsi_initialize_rq() Bart Van Assche
2017-05-24 6:09 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 22/31] scsi: Inline scsi_init_command() Bart Van Assche
2017-05-24 6:09 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 23/31] scsi: Move sense buffer pointer initialization into scsi_initialize_rq() Bart Van Assche
2017-05-24 6:10 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 24/31] scsi: Make scsi_initialize_rq() zero the entire struct scsi_cmnd Bart Van Assche
2017-05-24 6:10 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 25/31] scsi-mq: Make behavior scsi_mq_prep_fn() closer to that of scsi_prep_fn() Bart Van Assche
2017-05-24 6:11 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 26/31] scsi: Move the code for clearing private command data into scsi_dispatch_cmd() Bart Van Assche
2017-05-24 6:12 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 27/31] scsi: Consolidate more initialization code Bart Van Assche
2017-05-24 6:13 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 28/31] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it Bart Van Assche
2017-05-24 6:13 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 29/31] scsi: snic: Remove code that zeroes driver-private command data Bart Van Assche
2017-05-24 6:14 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 30/31] scsi: virtio: " Bart Van Assche
2017-05-24 6:14 ` Hannes Reinecke
2017-05-24 0:34 ` [PATCH 31/31] xen/scsifront: " Bart Van Assche
2017-05-24 6:14 ` Hannes Reinecke
2017-05-24 7:02 ` Juergen Gross
2017-05-24 2:31 ` [PATCH 00/31] SCSI patches for kernel v4.13 Martin K. Petersen
2017-05-24 3:55 ` Jens Axboe
2017-05-24 4:43 ` Bart Van Assche
2017-05-25 2:04 ` Martin K. Petersen
2017-06-01 14:08 ` Bart Van Assche
2017-06-01 14:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524150932.GC24798@htj.duckdns.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox