Re: [PATCH 11/31] block: Introduce queue flag QUEUE_FLAG_SCSI_SUP

Hannes Reinecke
2017-05-24T06:01:17Z

On 05/24/2017 02:34 AM, Bart Van Assche wrote:
> From the context where a SCSI command is submitted it is not always
> possible to figure out whether or not the queue the command is
> submitted to has struct scsi_request as the first member of its
> private data. Hence introduce the flag QUEUE_FLAG_SCSI_SUP.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Omar Sandoval <osandov@fb.com>
> Cc: Hannes Reinecke <hare@suse.com>
> ---
> block/bsg-lib.c | 1 +
> drivers/block/cciss.c | 1 +
> drivers/ide/ide-probe.c | 1 +
> drivers/scsi/scsi_lib.c | 2 ++
> drivers/scsi/scsi_transport_sas.c | 1 +
> include/linux/blkdev.h | 2 ++
> 6 files changed, 8 insertions(+)
>
Bit of an odd name; what about QUEUE_FLAG_SCSI_PDU?

Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)