From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 06/12] Make __scsi_remove_device go straight from BLOCKED to DEL Date: Fri, 2 Jun 2017 09:18:20 +0200 Message-ID: <20170602071820.GF560@lst.de> References: <20170601232711.29062-1-bart.vanassche@sandisk.com> <20170601232711.29062-7-bart.vanassche@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:51452 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbdFBHSW (ORCPT ); Fri, 2 Jun 2017 03:18:22 -0400 Content-Disposition: inline In-Reply-To: <20170601232711.29062-7-bart.vanassche@sandisk.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: "Martin K . Petersen" , James Bottomley , linux-scsi@vger.kernel.org, Christoph Hellwig , Israel Rukshin , Max Gurtovoy , Benjamin Block On Thu, Jun 01, 2017 at 04:27:05PM -0700, Bart Van Assche wrote: > If a device is blocked, make __scsi_remove_device() cause it to > transition to the DEL state. This means that all the commands > issued in .shutdown() will error in the mid-layer, thus making > the removal proceed without being stopped. > > This patch is a slightly modified version of a patch from James > Bottomley. This patch avoids that the following lockup occurs: Do we really need the printk for this case? And if we do we should probably rate limit it.