From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.garry@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
john.garry2@mail.dcu.ie, linuxarm@huawei.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler
Date: Thu, 8 Jun 2017 00:34:00 -0700 [thread overview]
Message-ID: <20170608073400.GA9292@infradead.org> (raw)
In-Reply-To: <04821e06-7541-1861-d52b-4df869570ca7@huawei.com>
Hi John,
sorry for dropping the ball, but your repost reminded me.
On Thu, Jun 01, 2017 at 11:36:55AM +0100, John Garry wrote:
> In the command completion code we need to check for abnormal completion due
> to underflow, but ignore it when it occurs in some commands, like inquiry.
> This is why we check for rw command - it is equivalent to !inquiry.
>
> I'll see if we can change the check to explicitly ignore certain commands
> which complete abnormally with underflow.
In general it should be up to the higher level and not the driver
to detect underflow, and that's how most (hopefully all, but I won't
bet on some older ones) of our drivers operate.
>
> > What about 32-byte CDs or things like Write Same?
> >
>
> You're talking about VARIABLE_LENGTH_CMD (opcode 0x7f) for 32-byte CDs,
> right?
Yes.
next prev parent reply other threads:[~2017-06-08 7:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 14:32 [PATCH v3 00/23] hisi_sas: hip08 support John Garry
2017-05-31 14:32 ` [PATCH v3 01/23] scsi: hisi_sas: fix timeout check in hisi_sas_internal_task_abort() John Garry
2017-05-31 14:32 ` [PATCH v3 02/23] scsi: hisi_sas: define hisi_sas_device.device_id as int John Garry
2017-05-31 14:32 ` [PATCH v3 03/23] scsi: hisi_sas: optimise the usage of hisi_hba.lock John Garry
2017-05-31 14:32 ` [PATCH v3 04/23] scsi: hisi_sas: relocate get_ata_protocol() John Garry
2017-05-31 14:32 ` [PATCH v3 05/23] scsi: hisi_sas: relocate sata_done_v2_hw() John Garry
2017-05-31 14:32 ` [PATCH v3 06/23] scsi: hisi_sas: relocate get_ncq_tag_v2_hw() John Garry
2017-05-31 14:32 ` [PATCH v3 07/23] scsi: hisi_sas: add pci_dev in hisi_hba struct John Garry
2017-05-31 14:33 ` [PATCH v3 08/23] scsi: hisi_sas: create hisi_sas_get_fw_info() John Garry
2017-05-31 14:33 ` [PATCH v3 09/23] scsi: hisi_sas: add skeleton v3 hw driver John Garry
2017-05-31 14:33 ` [PATCH v3 10/23] scsi: hisi_sas: add initialisation for v3 pci-based controller John Garry
2017-05-31 14:33 ` [PATCH v3 11/23] scsi: hisi_sas: add v3 hw init John Garry
2017-05-31 14:33 ` [PATCH v3 12/23] scsi: hisi_sas: add v3 hw PHY init John Garry
2017-05-31 14:33 ` [PATCH v3 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR John Garry
2017-06-01 5:41 ` Christoph Hellwig
2017-06-01 10:10 ` John Garry
2017-05-31 14:33 ` [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler John Garry
2017-06-01 5:41 ` Christoph Hellwig
2017-06-01 10:36 ` John Garry
2017-06-08 7:34 ` Christoph Hellwig [this message]
2017-06-08 12:09 ` John Garry
2017-05-31 14:33 ` [PATCH v3 15/23] scsi: hisi_sas: add v3 code to send SSP frame John Garry
2017-05-31 14:33 ` [PATCH v3 16/23] scsi: hisi_sas: add v3 code to send SMP frame John Garry
2017-05-31 14:33 ` [PATCH v3 17/23] scsi: hisi_sas: add v3 code to send ATA frame John Garry
2017-05-31 14:33 ` [PATCH v3 18/23] scsi: hisi_sas: add v3 code for itct setup and free John Garry
2017-05-31 14:33 ` [PATCH v3 19/23] scsi: hisi_sas: add v3 code to send internal abort command John Garry
2017-05-31 14:33 ` [PATCH v3 20/23] scsi: hisi_sas: add get_wideport_bitmap_v3_hw() John Garry
2017-05-31 14:33 ` [PATCH v3 21/23] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error John Garry
2017-05-31 14:33 ` [PATCH v3 22/23] scsi: hisi_sas: add v3 code to fill some more hw function pointers John Garry
2017-05-31 14:33 ` [PATCH v3 23/23] scsi: hisi_sas: modify internal abort dev flow for v3 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608073400.GA9292@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox