* [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs
[not found] <20170608081242.27061-1-gregkh@linuxfoundation.org>
@ 2017-06-08 8:12 ` Greg Kroah-Hartman
2017-06-08 12:31 ` Bryant G. Ly
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-06-08 8:12 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Bryant G. Ly, Michael Cyr,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
target-devel
The class_attrs pointer is going away and it's not even being used in
this driver, so just remove it entirely.
Cc: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Cc: Michael Cyr <mikecyr@linux.vnet.ibm.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>
Cc: <target-devel@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index d390325c99ec..b480878e3258 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3915,10 +3915,6 @@ static const struct target_core_fabric_ops ibmvscsis_ops = {
static void ibmvscsis_dev_release(struct device *dev) {};
-static struct class_attribute ibmvscsis_class_attrs[] = {
- __ATTR_NULL,
-};
-
static struct device_attribute dev_attr_system_id =
__ATTR(system_id, S_IRUGO, system_id_show, NULL);
@@ -3938,7 +3934,6 @@ ATTRIBUTE_GROUPS(ibmvscsis_dev);
static struct class ibmvscsis_class = {
.name = "ibmvscsis",
.dev_release = ibmvscsis_dev_release,
- .class_attrs = ibmvscsis_class_attrs,
.dev_groups = ibmvscsis_dev_groups,
};
--
2.13.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs
2017-06-08 8:12 ` [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs Greg Kroah-Hartman
@ 2017-06-08 12:31 ` Bryant G. Ly
0 siblings, 0 replies; 2+ messages in thread
From: Bryant G. Ly @ 2017-06-08 12:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: Michael Cyr, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
target-devel
> The class_attrs pointer is going away and it's not even being used in
> this driver, so just remove it entirely.
>
> Cc: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
> Cc: Michael Cyr <mikecyr@linux.vnet.ibm.com>
> Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: <linux-scsi@vger.kernel.org>
> Cc: <target-devel@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> index d390325c99ec..b480878e3258 100644
> --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> @@ -3915,10 +3915,6 @@ static const struct target_core_fabric_ops ibmvscsis_ops = {
>
> static void ibmvscsis_dev_release(struct device *dev) {};
>
> -static struct class_attribute ibmvscsis_class_attrs[] = {
> - __ATTR_NULL,
> -};
> -
> static struct device_attribute dev_attr_system_id =
> __ATTR(system_id, S_IRUGO, system_id_show, NULL);
>
> @@ -3938,7 +3934,6 @@ ATTRIBUTE_GROUPS(ibmvscsis_dev);
> static struct class ibmvscsis_class = {
> .name = "ibmvscsis",
> .dev_release = ibmvscsis_dev_release,
> - .class_attrs = ibmvscsis_class_attrs,
> .dev_groups = ibmvscsis_dev_groups,
> };
>
Thanks Greg, ACK.
-Bryant
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-08 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170608081242.27061-1-gregkh@linuxfoundation.org>
2017-06-08 8:12 ` [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs Greg Kroah-Hartman
2017-06-08 12:31 ` Bryant G. Ly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox