linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	James Smart <james.smart@broadcom.com>
Subject: [PATCH 09/11] Fix crash in lpfc_sli_ringtxcmpl_put when nvmet gets an abort request.
Date: Thu, 15 Jun 2017 22:56:49 -0700	[thread overview]
Message-ID: <20170616055651.9674-10-jsmart2021@gmail.com> (raw)
In-Reply-To: <20170616055651.9674-1-jsmart2021@gmail.com>

When running nvme detach-ns /dev/nvme0n1 -n 1 command,
the nvmet lpfc driver crashes with this stack dump:

kernel BUG at /root/NVME/lpfc_8.4/lpfc_sli.c:1393!
invalid opcode: 0000 [#1] SMP
Workqueue: nvmet-fc-cpu0 nvmet_fc_do_work_on_cpu [nvmet_fc]
 lpfc_sli4_issue_wqe+0x357/0x440 [lpfc]
 lpfc_nvmet_xmt_fcp_abort+0x36b/0x5c0 [lpfc]
 nvmet_fc_abort_op+0x30/0x50 [nvmet_fc]
 nvmet_fc_do_work_on_cpu+0xd9/0x130 [nvmet_fc]
 process_one_work+0x14e/0x410
 worker_thread+0x116/0x490
 kthread+0xc7/0xe0
 ret_from_fork+0x3f/0x70

Crash is due to an uninitialized iocbq->vport pointer.

Explicitly set the iocbq->vport field to phba->pport in
lpfc_nvmet_sol_fcp_issue_abort as it does all abort iocbq
initialization in the routine.  Using phba->pport is ok because
target does not support NPIV instances.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_nvmet.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
index 5fb29735e236..7dc061a14f95 100644
--- a/drivers/scsi/lpfc/lpfc_nvmet.c
+++ b/drivers/scsi/lpfc/lpfc_nvmet.c
@@ -2523,6 +2523,7 @@ lpfc_nvmet_sol_fcp_issue_abort(struct lpfc_hba *phba,
 	abts_wqeq->iocb_cmpl = 0;
 	abts_wqeq->iocb_flag |= LPFC_IO_NVME;
 	abts_wqeq->context2 = ctxp;
+	abts_wqeq->vport = phba->pport;
 	rc = lpfc_sli4_issue_wqe(phba, LPFC_FCP_RING, abts_wqeq);
 	spin_unlock_irqrestore(&phba->hbalock, flags);
 	if (rc == WQE_SUCCESS) {
-- 
2.11.0

  parent reply	other threads:[~2017-06-16  5:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16  5:56 [PATCH 00/11] lpfc updates for 11.4.0.1 James Smart
2017-06-16  5:56 ` [PATCH 01/11] Fix system panic when express lane enabled James Smart
2017-06-16  7:50   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 02/11] Fix nvme_info sysfs output to be consistent James Smart
2017-06-16  7:51   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 03/11] Vport creation is failing with "Link Down" error James Smart
2017-06-16  7:51   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 04/11] Reduce time spent in IRQ for received NVME commands James Smart
2017-06-16  7:52   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 05/11] Break up IO ctx list into a separate get and put list James Smart
2017-06-16  7:59   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 06/11] Fix SLI3 drivers attempting NVME ELS commands James Smart
2017-06-16  8:00   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 07/11] Fix crash after firmware flash when IO is running James Smart
2017-06-16  8:01   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 08/11] Fix crash doing IO with resets James Smart
2017-06-16  8:02   ` Hannes Reinecke
2017-06-16  5:56 ` James Smart [this message]
2017-06-16  8:02   ` [PATCH 09/11] Fix crash in lpfc_sli_ringtxcmpl_put when nvmet gets an abort request Hannes Reinecke
2017-06-16  5:56 ` [PATCH 10/11] Driver responds LS_RJT to Beacon Off ELS - Linux James Smart
2017-06-16  8:03   ` Hannes Reinecke
2017-06-16  5:56 ` [PATCH 11/11] lpfc: update to revision to 11.4.0.1 James Smart
2017-06-16  8:03   ` Hannes Reinecke
2017-06-20  1:42 ` [PATCH 00/11] lpfc updates for 11.4.0.1 Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170616055651.9674-10-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).